[GR-30323][GR-30494] Remove GIL from python internal libs.

PullRequest: graalpython/1737

Author: gilles-duboscq

.gitignore

@@ -68,3 +68,8 @@ graalpython/lib-python/3/test/data
 !graalpython/lib-python/3/test/data/README
 /venv
 *.code-workspace
+graalpython/com.oracle.graal.python.test/src/tests/cpyext/*.c
+graalpython/com.oracle.graal.python.test/src/tests/cpyext/*.sha256
+graalpython/com.oracle.graal.python.test/src/tests/cpyext/As_FileDescriptor_Testfile
+graalpython/lib-python/3/lib2to3/Grammar3.8.5.alpha.0.pickle
+graalpython/lib-python/3/lib2to3/PatternGrammar3.8.5.alpha.0.pickle

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/PythonLanguage.java

@@ -325,7 +325,8 @@ private RootNode parseWithArguments(ParsingRequest request) {
         CompilerDirectives.transferToInterpreter();
         final PythonLanguage lang = this;
         final RootNode executableNode = new RootNode(lang) {
-            @Node.Child private RootNode rootNode;
+            @Child private RootNode rootNode;
+            @Child private GilNode gilNode;
 
             protected Object[] preparePArguments(VirtualFrame frame) {
                 int argumentsLength = frame.getArguments().length;
@@ -347,9 +348,18 @@ public Object execute(VirtualFrame frame) {
                     CompilerDirectives.transferToInterpreterAndInvalidate();
                     parse(context, frame);
                 }
-                Object[] args = preparePArguments(frame);
-                Object result = InvokeNode.invokeUncached(rootNode.getCallTarget(), args);
-                return result;
+                if (gilNode == null) {
+                    CompilerDirectives.transferToInterpreterAndInvalidate();
+                    gilNode = insert(GilNode.create());
+                }
+                boolean wasAcquired = gilNode.acquire();
+                try {
+                    Object[] args = preparePArguments(frame);
+                    Object result = InvokeNode.invokeUncached(rootNode.getCallTarget(), args);
+                    return result;
+                } finally {
+                    gilNode.release(wasAcquired);
+                }
             }
 
             private void parse(PythonContext context, VirtualFrame frame) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/PythonBuiltinClassType.java

@@ -685,17 +685,12 @@ static long asJavaLongWithState(PythonBuiltinClassType type, ThreadState state,
     @ExportMessage
     public Object lookupAttributeInternal(ThreadState state, String attribName, boolean strict,
                     @Cached ConditionProfile gotState,
-                    @Cached.Exclusive @Cached PythonAbstractObject.LookupAttributeNode lookup, @Cached.Exclusive @Cached GilNode gil) {
-        boolean mustRelease = gil.acquire();
-        try {
-            VirtualFrame frame = null;
-            if (gotState.profile(state != null)) {
-                frame = PArguments.frameForCall(state);
-            }
-            return lookup.execute(frame, this, attribName, strict);
-        } finally {
-            gil.release(mustRelease);
+                    @Cached.Exclusive @Cached PythonAbstractObject.LookupAttributeNode lookup) {
+        VirtualFrame frame = null;
+        if (gotState.profile(state != null)) {
+            frame = PArguments.frameForCall(state);
         }
+        return lookup.execute(frame, this, attribName, strict);
     }
 
     @ExportMessage

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/ThreadModuleBuiltins.java

@@ -42,6 +42,7 @@
 
 import static com.oracle.graal.python.builtins.objects.thread.AbstractPythonLock.TIMEOUT_MAX;
 
+import java.io.PrintWriter;
 import java.lang.ref.WeakReference;
 import java.util.List;
 
@@ -51,13 +52,13 @@
 import com.oracle.graal.python.builtins.PythonBuiltinClassType;
 import com.oracle.graal.python.builtins.PythonBuiltins;
 import com.oracle.graal.python.builtins.objects.PNone;
+import com.oracle.graal.python.builtins.objects.exception.PBaseException;
 import com.oracle.graal.python.builtins.objects.function.PKeyword;
 import com.oracle.graal.python.builtins.objects.thread.PLock;
 import com.oracle.graal.python.builtins.objects.thread.PRLock;
 import com.oracle.graal.python.builtins.objects.thread.PThread;
 import com.oracle.graal.python.builtins.objects.thread.PThreadLocal;
 import com.oracle.graal.python.nodes.ErrorMessages;
-import com.oracle.graal.python.nodes.WriteUnraisableNode;
 import com.oracle.graal.python.nodes.argument.keywords.ExpandKeywordStarargsNode;
 import com.oracle.graal.python.nodes.argument.positional.ExecutePositionalStarargsNode;
 import com.oracle.graal.python.nodes.call.CallNode;
@@ -204,14 +205,24 @@ long start(VirtualFrame frame, Object cls, Object callable, Object args, Object
                 } catch (PythonThreadKillException e) {
                     return;
                 } catch (PException e) {
-                    WriteUnraisableNode.getUncached().execute(e.getUnreifiedException(), "in thread started by", callable);
+                    dumpError(context, e.getUnreifiedException(), callable);
+                    // TODO (cbasca): when GR-30386 is completed use the intrinsified
+                    // sys.unraisablehook
+                    // WriteUnraisableNode.getUncached().execute(e.getUnreifiedException(), "in
+                    // thread started by", callable);
                 }
             }, env.getContext(), context.getThreadGroup());
 
             PThread pThread = factory().createPythonThread(cls, thread);
             pThread.start();
             return pThread.getId();
         }
+
+        @TruffleBoundary
+        static void dumpError(PythonContext context, PBaseException exception, Object object) {
+            PrintWriter err = new PrintWriter(context.getStandardErr());
+            err.println(String.format("%s in thread started by %s", exception.toString(), object));
+        }
     }
 
     @Builtin(name = "_set_sentinel", minNumOfPositionalArgs = 0)