[GR-59463] Immortalize native Py_True and Py_False

PullRequest: graalpython/3542

Author: qunaibit

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/capi/CApiContext.java

@@ -318,6 +318,10 @@ public CApiContext(PythonContext context, Object llvmLibrary, boolean useNativeB
             primitiveNativeWrapperCache[i] = PrimitiveNativeWrapper.createInt(value);
         }
 
+        // initialize Py_True and Py_False
+        context.getTrue().setNativeWrapper(PrimitiveNativeWrapper.createBool(true));
+        context.getFalse().setNativeWrapper(PrimitiveNativeWrapper.createBool(false));
+
         this.gcTask = new BackgroundGCTask(context);
     }
 
@@ -432,6 +436,12 @@ public PrimitiveNativeWrapper getCachedPrimitiveNativeWrapper(long l) {
         return getCachedPrimitiveNativeWrapper((int) l);
     }
 
+    public PrimitiveNativeWrapper getCachedBooleanPrimitiveNativeWrapper(boolean b) {
+        PythonAbstractObjectNativeWrapper wrapper = b ? getContext().getTrue().getNativeWrapper() : getContext().getFalse().getNativeWrapper();
+        assert wrapper.getRefCount() > 0;
+        return (PrimitiveNativeWrapper) wrapper;
+    }
+
     /**
      * Returns or allocates (on demand) the native array {@code PyInterpreterState.small_ints} and
      * write all elements to it.

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/capi/PrimitiveNativeWrapper.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2024, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -255,6 +255,11 @@ void toNative(
                     @Bind("$node") Node inliningTarget,
                     @Cached CApiTransitions.FirstToNativeNode firstToNativeNode) {
         if (!isNative()) {
+            if (isBool()) {
+                assert (PythonContext.get(inliningTarget).getCApiContext().getCachedBooleanPrimitiveNativeWrapper(value != 0) == this);
+                setNativePointer(firstToNativeNode.execute(inliningTarget, this, true /* immortal */));
+                return;
+            }
             // small int values are cached and will be immortal
             boolean immortal = isIntLike() && CApiGuards.isSmallLong(value);
             // if this wrapper wraps a small int value, this wrapper is one of the cached primitive