Fixed bug which threw an error due to the presence of duplicate cursors with DRCP

Author: sharadraju

doc/src/release_notes.rst

@@ -58,6 +58,9 @@ Thin Mode Changes
 #)  Added support for usage with extension of Array.prototype methods
     See `Issue #1653 <https://github.com/oracle/node-oracledb/issues/1653>`__.
 
+#)  Fixed bug which threw an error due to the presence of duplicate cursors
+    with DRCP.
+
 Thick Mode Changes
 +++++++++++++++++++
 

lib/thin/protocol/messages/base.js

@@ -282,7 +282,7 @@ class Message {
       const flags = buf.readUB4();              // session flags
       if (flags & constants.TNS_SESSGET_SESSION_CHANGED) {
         if (this.connection._drcpEstablishSession) {
-          this.connection.statementCache.clearOpenCursors();
+          this.connection.statementCache.clearCursors();
         }
       }
       this.connection._drcpEstablishSession = false;

lib/thin/protocol/protocol.js

@@ -167,7 +167,7 @@ class Protocol {
     this.txnInProgress = Boolean(message.callStatus & constants.TNS_EOCS_FLAGS_TXN_IN_PROGRESS);
     // processes the call status flags returned by the server.
     if (message.callStatus & constants.TNS_EOCS_FLAGS_SESS_RELEASE) {
-      message.connection.statementCache.clearOpenCursors();
+      message.connection.statementCache.clearCursors();
     }
 
     if (message.errorOccurred) {

lib/thin/statementCache.js

@@ -71,12 +71,12 @@ class StatementCache {
   }
 
   //---------------------------------------------------------------------------
-  //clearOpenCursors() {
+  //clearCursors() {
   // Clears the list of open cursors and removes the list of cursors that
   // need to be closed. This is required when a DRCP session change has
   // taken place as the cursor ID values are invalidated.
   //---------------------------------------------------------------------------
-  clearOpenCursors() {
+  clearCursors() {
     const newOpenCursors = new Set();
     for (const stmt of this._openCursors) {
       if (stmt.inUse || stmt.returnToCache) {
@@ -86,6 +86,7 @@ class StatementCache {
       stmt._clearState();
     }
     this._openCursors = newOpenCursors;
+    this._cursorsToClose.clear();
   }
 
   //---------------------------------------------------------------------------

test/dataTypeVector4.js

@@ -335,7 +335,7 @@ describe('298. dataTypeVector4.js', function() {
           `, binds);
     }
 
-    await connection.execute(`delete /*+ parallel(4) */ from ${tableName} 
+    await connection.execute(`delete /*+ parallel(4) */ from ${tableName}
            where vector_distance(VectorCol, ${sampleVector}, euclidean) < 10`);
 
     const result = await connection.execute(`
@@ -373,7 +373,7 @@ describe('298. dataTypeVector4.js', function() {
           `, binds);
     }
 
-    await connection.execute(`delete /*+ no_parallel(4) */ from ${tableName} 
+    await connection.execute(`delete /*+ no_parallel(4) */ from ${tableName}
            where vector_distance(VectorCol, ${sampleVector}, euclidean) < 10`);
 
     const result = await connection.execute(`