an issue about NodeTag definition.

[liujinyang-highgo]

hi,
Now， struct NodeTag in nodes.h as below：
typedef enum NodeTag
{
T_Invalid = 0,

/* pgpool Extension */
			T_PgpoolVariableSetStmt,
			T_PgpoolVariableShowStmt,
			T_PgpoolQueryCacheStmt,

#include "nodetags.h"
} NodeTag;

The content of nodetags.h as below:
T_List = 1,
T_Alias = 2,
T_RangeVar = 3,
T_TableFunc = 4,
T_IntoClause = 5,
T_Var = 6,
T_Const = 7,
....
....

I think that will cause T_PgpoolVariableSetStmt and T_List has same value is 1, is there any potential risk？
I think the right definition should as below, please help clarify it, thanks a lot!
typedef enum NodeTag
{
T_Invalid = 0,
#include "nodetags.h"
/* pgpool Extension */
T_PgpoolVariableSetStmt,
T_PgpoolVariableShowStmt,
T_PgpoolQueryCacheStmt,
} NodeTag;

Thanks!

[tatsuo-ishii]

Thank you for the report!

I think that will cause T_PgpoolVariableSetStmt and T_List has same value is 1,

Yes.

is there any potential risk？

As far as I know, probably it's harmless. If T_Pgpool* is passed to raw_expression_tree_walker(), the function may misbehaves. But it seems there's no such a calling pattern exists in pgpool. Other concern is, nodeToString(). I was afraid that if T_PgppolVariableStmt is passed to to the function, it may produce a string for T_List. Fortunately, nodeToString() does not implement the code for T_Pgppol*. It will just produce an empty string and probably there's no such a place where nodeToString() is called with T_Pgpool*.

I think the right definition should as below

I agree.