deploy: 84352e3

Author: phoenixide

LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js

@@ -128,6 +128,8 @@
         }
     };
 
+    global._Brackets_MessageBroker = MessageBroker;
+
     /**
      * Runtime Domain. Implements remote commands for "Runtime.*"
      */
@@ -390,27 +392,69 @@
     function onDocumentClick(event) {
         // Get the user's current selection
         const selection = window.getSelection();
-
-        // Check if there is a selection
-        if (selection.toString().length > 0) {
-            // if there is any selection like text or others, we don't see it as a live selection event
-            // Eg: user may selects ome text in live preview to copy, in which case we should nt treat it
-            // as a live select.
-            return;
-        }
         var element = event.target;
         if (element && element.hasAttribute('data-brackets-id')) {
-            MessageBroker.send({
-                "tagId": element.getAttribute('data-brackets-id'),
-                "nodeID": element.id,
-                "nodeClassList": element.classList,
-                "nodeName": element.nodeName,
-                "allSelectors": _getAllInheritedSelectorsInOrder(element),
-                "contentEditable": element.contentEditable === 'true',
-                "clicked": true
-            });
+            // Check if it's a double-click for direct editing
+            if (event.detail === 2 && !['INPUT', 'TEXTAREA', 'SELECT'].includes(element.tagName)) {
+                // Double-click detected, enable direct editing
+                // Make the element editable
+                if (window._LD && window._LD.DOMEditHandler) {
+                    // Use the existing DOMEditHandler to handle the edit
+                    window._LD.startEditing(element);
+                } else {
+                    MessageBroker.send({
+                        "tagId": element.getAttribute('data-brackets-id'),
+                        "nodeID": element.id,
+                        "nodeClassList": element.classList,
+                        "nodeName": element.nodeName,
+                        "allSelectors": _getAllInheritedSelectorsInOrder(element),
+                        "contentEditable": element.contentEditable === 'true',
+                        "clicked": true,
+                        "edit": true
+                    });
+                }
+
+                // Prevent default behavior and stop propagation
+                event.preventDefault();
+                event.stopPropagation();
+            } else {
+                // Regular click, just send the information
+                // Check if there is a selection
+                if (selection.toString().length > 0) {
+                    // if there is any selection like text or others, we don't see it as a live selection event
+                    // Eg: user may selects ome text in live preview to copy, in which case we should nt treat it
+                    // as a live select.
+                    return;
+                }
+                MessageBroker.send({
+                    "tagId": element.getAttribute('data-brackets-id'),
+                    "nodeID": element.id,
+                    "nodeClassList": element.classList,
+                    "nodeName": element.nodeName,
+                    "allSelectors": _getAllInheritedSelectorsInOrder(element),
+                    "contentEditable": element.contentEditable === 'true',
+                    "clicked": true
+                });
+            }
         }
     }
     window.document.addEventListener("click", onDocumentClick);
+    window.document.addEventListener("keydown", function (e) {
+        // for undo. refer to LivePreviewEdit.js file 'handleLivePreviewEditOperation' function
+        if ((e.ctrlKey || e.metaKey) && e.key.toLowerCase() === "z") {
+            MessageBroker.send({
+                livePreviewEditEnabled: true,
+                undoLivePreviewOperation: true
+            });
+        }
+
+        // for redo
+        if ((e.ctrlKey || e.metaKey) && e.key.toLowerCase() === "y") {
+            MessageBroker.send({
+                livePreviewEditEnabled: true,
+                redoLivePreviewOperation: true
+            });
+        }
+    });
 
 }(this));

LiveDevelopment/BrowserScripts/LivePreviewTransportRemote.js

@@ -103,6 +103,37 @@
         }
     }
 
+    function createLRU(max = 100) {
+        const map = new Map();
+
+        return {
+            set: function (key, value = true) {
+                if (map.has(key)) {
+                    map.delete(key); // refresh order
+                }
+                map.set(key, value);
+                if (map.size > max) {
+                    const oldestKey = map.keys().next().value;
+                    map.delete(oldestKey);
+                }
+            },
+            has: function (key) {
+                if (!map.has(key)) {
+                    return false;
+                }
+                const val = map.get(key);
+                map.delete(key);   // refresh order
+                map.set(key, val);
+                return true;
+            },
+            size: function() {
+                return map.size;
+            }
+        };
+    }
+
+    const processedMessageIDs = createLRU(1000);
+
     const clientID = "" + Math.round( Math.random()*1000000000);
 
     const worker = new Worker(TRANSPORT_CONFIG.LIVE_DEV_REMOTE_WORKER_SCRIPTS_FILE_NAME);
@@ -218,7 +249,12 @@
                 case 'MESSAGE_FROM_PHOENIX':
                     if (self._callbacks && self._callbacks.message) {
                         const clientIDs = event.data.clientIDs,
-                            message = event.data.message;
+                            message = event.data.message,
+                            messageID = event.data.messageID;
+                        if(messageID && processedMessageIDs.has(messageID)){
+                            return; // we have already processed this message.
+                        }
+                        processedMessageIDs.set(messageID, true);
                         if(clientIDs.includes(clientID) || clientIDs.length === 0){
                             // clientIDs.length = 0 if the message is intended for all clients
                             self._callbacks.message(message);
@@ -264,6 +300,7 @@
             _postLivePreviewMessage({
                 type: 'BROWSER_MESSAGE',
                 clientID: clientID,
+                messageID: crypto.randomUUID(),
                 message: msgStr
             });
         },