test: fix flaky Series.Add-Comment.Logic.Add a comment

Fix #1465

Author: php-coder

src/main/frontend/src/components/AddCommentForm.js

@@ -100,12 +100,12 @@ class AddCommentFormView extends React.PureComponent {
 						{ l10n['t_server_error'] || 'Server error' }
 					</div>
 					<div className="form-group form-group-sm">
-						<label htmlFor="comment" className="control-label col-sm-3">
+						<label htmlFor="new-comment" className="control-label col-sm-3">
 							{ l10n['t_comment'] || 'Comment' }
 						</label>
 						<div className="col-sm-6">
 							<textarea
-								id="comment"
+								id="new-comment"
 								className="form-control"
 								cols="22"
 								rows="3"
@@ -116,7 +116,7 @@ class AddCommentFormView extends React.PureComponent {
 					</div>
 					<div className="col-sm-offset-3 col-sm-4">
 						<span
-							id="comment.errors"
+							id="new-comment.errors"
 							className={ `help-block ${hasValidationErrors ? '' : 'hidden'}` }>
 							{ validationErrors.join(', ') }
 						</span>

src/test/robotframework/selenium.utils.robot

@@ -33,6 +33,8 @@ Link Should Point To
 	${url}=          Get Element Attribute  ${locator}@href
 	Should Be Equal  ${expectedUrl}  ${url}
 
+# NOTE: this keyword should be used as a last resort. Prefer "Wait Until Page Contains Element"
+# with some other keyword for checking element's state where possible
 Wait Until Element Value Is
 	[Documentation]     Hybrid of "Wait Until Page Contains Element" and "Textfield Value Should Be" keywords
 	[Arguments]         ${id}  ${text}

src/test/robotframework/series/add-comment/logic.robot

@@ -9,10 +9,11 @@ Force Tags      series  add-comment  logic
 
 *** Test Cases ***
 Add a comment
-	Input Text                        id:comment  A comment
+	Input Text                        id:new-comment  A comment
 	Submit Form                       id:add-comment-form
 	Wait Until Page Does Not Contain  id:add-comment-form
-	Wait Until Element Value Is       comment  A comment
+	Wait Until Page Contains Element  id:comment
+	Element Text Should Be            id:comment  A comment
 
 *** Keywords ***
 Before Test Suite