fixed aspectRatio if width and height is not called first #57

oscarotero · oscarotero · commit a9e3d55b1755 · 2015-05-09T13:10:23.000+02:00
diff --git a/src/Adapters/Adapter.php b/src/Adapters/Adapter.php
@@ -404,7 +404,7 @@ public function getHeight()
      */
     public function getAspectRatio()
     {
-        if (!empty($this->width) && (strpos($this->width, '%') === false) && !empty($this->height) && (strpos($this->height, '%') === false)) {
+        if ($this->width && (strpos($this->width, '%') === false) && $this->height && (strpos($this->height, '%') === false)) {
             return round(($this->height / $this->width) * 100, 3);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -404,7 +404,7 @@ public function getHeight()`
`404`	`404`	`*/`
`405`	`405`	`public function getAspectRatio()`
`406`	`406`	`{`
`407`		`- if (!empty($this->width) && (strpos($this->width, '%') === false) && !empty($this->height) && (strpos($this->height, '%') === false)) {`
	`407`	`+ if ($this->width && (strpos($this->width, '%') === false) && $this->height && (strpos($this->height, '%') === false)) {`
`408`	`408`	`return round(($this->height / $this->width) * 100, 3);`
`409`	`409`	`}`
`410`	`410`	`}`