refactor: add method to set settings on embed

Author: Dominik Jansen

README.md

@@ -328,17 +328,14 @@ If you need to pass settings to your detectors, you can add settings to the `Ext
 
 ```php
 use Embed\Embed;
-use Embed\ExtractorFactory;
 
 $embed = new Embed();
-$extractorFactory = new ExtractorFactory([
+$embed->setSettings([
     'oembed:query_parameters' => [],  //Extra parameters send to oembed
     'twitch:parent' => 'example.com', //Required to embed twitch videos as iframe
     'facebook:token' => '1234|5678',  //Required to embed content from Facebook
     'instagram:token' => '1234|5678', //Required to embed content from Instagram
 ]);
-$embed->setExtractorFactory($extractorFactory);
-
 $info = $embed->get($url);
 ```
 

demo/index.php

@@ -207,14 +207,13 @@ function printCode(?string $code, bool $asHtml = true): void
                     'Cache-Control' => 'max-age=0,no-cache',
                 ]);
 
-                $extractorFactory = new \Embed\ExtractorFactory(
+                $embed->setSettings(
                     [
                         'twitch:parent' => $_SERVER['SERVER_NAME'] === 'localhost' ? null : $_SERVER['SERVER_NAME'],
                         'instagram:token' => getParam('instagram_token'),
                         'facebook:token' => getParam('facebook_token'),
                     ]
                 );
-                $embed->setExtractorFactory($extractorFactory);
                 $info = $embed->get(getUrl());
             } catch (Exception $exception) {
                 echo '<pre>';

src/Embed.php

@@ -57,6 +57,11 @@ public function getExtractorFactory(): ExtractorFactory
         return $this->extractorFactory;
     }
 
+    public function setSettings(array $settings): void
+    {
+        $this->extractorFactory->setSettings($settings);
+    }
+
     private function extract(RequestInterface $request, ResponseInterface $response, bool $redirect = true): Extractor
     {
         $uri = $this->crawler->getResponseUri($response) ?: $request->getUri();
@@ -81,9 +86,4 @@ private function mustRedirect(Extractor $extractor): bool
 
         return $extractor->redirect !== null;
     }
-
-    public function setExtractorFactory(ExtractorFactory $extractorFactory): void
-    {
-        $this->extractorFactory = $extractorFactory;
-    }
 }

src/ExtractorFactory.php

@@ -77,4 +77,9 @@ public function setDefault(string $class): void
     {
         $this->default = $class;
     }
+
+    public function setSettings(array $settings): void
+    {
+        $this->settings = $settings;
+    }
 }