trying to fix encoded urls

oscarotero · oscarotero · commit f30ce58e57c2 · 2016-07-27T17:55:59.000+02:00
diff --git a/demo/index.php b/demo/index.php
@@ -11,11 +11,13 @@ function get($name, $default = '')
     }
 
     if ($name === 'url') {
-        if (!filter_var($_GET['url'], FILTER_VALIDATE_URL)) {
+        $url = urldecode($_GET['url']);
+
+        if (!filter_var($url, FILTER_VALIDATE_URL)) {
             return 'http://doNotTryToXSS.invalid';
         }
 
-        return urldecode($_GET['url']);
+        return $url;
     }
 
     return $_GET[$name];

Original file line number	Diff line number	Diff line change
`@@ -11,11 +11,13 @@ function get($name, $default = '')`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`if ($name === 'url') {`
`14`		`- if (!filter_var($_GET['url'], FILTER_VALIDATE_URL)) {`
	`14`	`+ $url = urldecode($_GET['url']);`
	`15`	`+`
	`16`	`+ if (!filter_var($url, FILTER_VALIDATE_URL)) {`
`15`	`17`	`return 'http://doNotTryToXSS.invalid';`
`16`	`18`	`}`
`17`	`19`
`18`		`- return urldecode($_GET['url']);`
	`20`	`+ return $url;`
`19`	`21`	`}`
`20`	`22`
`21`	`23`	`return $_GET[$name];`