Fix phpstan errors

Author: jaapio

phive.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phive xmlns="https://phar.io/phive">
-  <phar name="phpstan" version="^0.9.1" installed="0.10.7" location="./tools/phpstan" copy="true"/>
+  <phar name="phpstan" version="^0.9.1" installed="0.11.4" location="./tools/phpstan" copy="true"/>
   <phar name="phpunit" version="^7.0" installed="7.5.7" location="./tools/phpunit" copy="true"/>
   <phar name="phpbench" version="^0.16.9" installed="0.16.9" location="./tools/phpbench" copy="true"/>
 </phive>

phpstan.neon

@@ -2,10 +2,14 @@ parameters:
     ignoreErrors:
 
         - '#Method phpDocumentor\\Reflection\\File\\LocalFile::\md5\(\) should return string but returns string\|false\.#'
+        - '#Else branch is unreachable because ternary operator condition is always true\.#'
+        # Design issue that needs to be fixed in factory strategies.
+        - '#Return type \(phpDocumentor\\Reflection\\DocBlock\|null\) of method phpDocumentor\\Reflection\\Php\\Factory\\DocBlock::create\(\) should be compatible with return type \(phpDocumentor\\Reflection\\Element\) of method phpDocumentor\\Reflection\\Php\\ProjectFactoryStrategy::create\(\)#'
         #
         # all these $fqsen errors indicate the need for a decorator class around PhpParser\Node to hold the public $fqsen that Reflection is giving it)
         #
         # src/phpDocumentor/Reflection/NodeVisitor/ElementNameResolver.php
+        - '#Access to an undefined property PhpParser\\Node::\$fqsen\.#'
         - '#Access to an undefined property PhpParser\\Node\\Stmt\\Namespace_::\$fqsen\.#'
         - '#Access to an undefined property PhpParser\\Node\\Stmt\\Interface_::\$fqsen\.#'
         - '#Access to an undefined property PhpParser\\Node\\Stmt\\Function_::\$fqsen\.#'
@@ -35,6 +39,9 @@ parameters:
         # there are some Elements doubling as Arguments, so we should probably tie their classes together somehow
         # src/phpDocumentor/Reflection/Php/Factory/Function_.php
         - '#Parameter \#1 \$argument of method phpDocumentor\\Reflection\\Php\\Function\_::addArgument\(\) expects phpDocumentor\\Reflection\\Php\\Argument, phpDocumentor\\Reflection\\Element given\.#'
+
+        # Type hint in php-parser is incorrect.
+        - '#Cannot cast PhpParser\\Node\\Expr\|string to string.#'
         #
         #
         # many classes here that should have relationship to Element

src/phpDocumentor/Reflection/NodeVisitor/ElementNameResolver.php

@@ -39,15 +39,15 @@ final class ElementNameResolver extends NodeVisitorAbstract
     /**
      * Resets the object to a known state before start processing.
      */
-    public function beforeTraverse(array $nodes): void
+    public function beforeTraverse(array $nodes)
     {
         $this->resetState('\\');
     }
 
     /**
      * Performs a reset of the added element when needed.
      */
-    public function leaveNode(Node $node): void
+    public function leaveNode(Node $node)
     {
         switch (get_class($node)) {
             case Namespace_::class:
@@ -83,12 +83,11 @@ public function enterNode(Node $node): ?int
             case Class_::class:
             case Trait_::class:
             case Interface_::class:
-                $this->parts->push((string) $node->name);
-
                 if (empty($node->name)) {
                     return NodeTraverser::DONT_TRAVERSE_CHILDREN;
                 }
 
+                $this->parts->push((string)$node->name);
                 $node->fqsen = new Fqsen($this->buildName());
                 break;
             case Function_::class:

src/phpDocumentor/Reflection/Php/Factory/DocBlock.php

@@ -59,7 +59,7 @@ public function matches($object): bool
      * @param Context $context of the created object
      * @return null|DocBlockDescriptor
      */
-    public function create($object, StrategyContainer $strategies, ?Context $context = null)
+    public function create($object, StrategyContainer $strategies, ?Context $context = null): ?DocBlockDescriptor
     {
         if ($object === null) {
             return null;

src/phpDocumentor/Reflection/Php/ProjectFactory.php

@@ -16,6 +16,7 @@
 
 use phpDocumentor\Reflection\DocBlockFactory;
 use phpDocumentor\Reflection\Exception;
+use phpDocumentor\Reflection\File as SourceFile;
 use phpDocumentor\Reflection\Fqsen;
 use phpDocumentor\Reflection\PrettyPrinter;
 use phpDocumentor\Reflection\Project as ProjectInterface;
@@ -66,7 +67,7 @@ public static function createInstance(): self
      * Creates a project from the set of files.
      *
      * @param string $name
-     * @param File[] $files
+     * @param SourceFile[] $files
      * @throws Exception when no matching strategy was found.
      */
     public function create($name, array $files): ProjectInterface

src/phpDocumentor/Reflection/Types/NamespaceNodeToContext.php

@@ -44,7 +44,7 @@ private function aliasesToFullyQualifiedNames(Namespace_ $namespace) : array
     }
 
     /**
-     * @param null|Namespace_ $namespace
+     * @param Namespace_ $namespace
      *
      * @return Use_[]|GroupUse[]
      */