add more unit tests and normalize the "__toString" methods

-> fix code style + psalm reported errors

Author: voku

src/DocBlock/Tags/Example.php

@@ -154,9 +154,15 @@ public function __toString() : string
         $content = (string) $this->content;
 
         return $filePath
-            . ($startingLine !== '' ? ($filePath !== '' ? ' ' : '') . $startingLine : '')
-            . ($lineCount !== '' ? ($filePath !== '' || $startingLine !== '' ? ' ' : '') . $lineCount : '')
-            . ($content !== '' ? ($filePath !== '' || $startingLine !== '' || $lineCount !== '' ? ' ' : '') . $content : '');
+            . ($startingLine !== ''
+                ? ($filePath !== '' ? ' ' : '') . $startingLine
+                : '')
+            . ($lineCount !== ''
+                ? ($filePath !== '' || $startingLine !== '' ? ' ' : '') . $lineCount
+                : '')
+            . ($content !== ''
+                ? ($filePath !== '' || $startingLine !== '' || $lineCount !== '' ? ' ' : '') . $content
+                : '');
     }
 
     /**

src/DocBlock/Tags/Method.php

@@ -212,6 +212,7 @@ public function __toString() : string
         foreach ($this->arguments as $argument) {
             $arguments[] = $argument['type'] . ' $' . $argument['name'];
         }
+
         $argumentStr = '(' . implode(', ', $arguments) . ')';
 
         if ($this->description) {

src/DocBlock/Tags/Param.php

@@ -149,7 +149,7 @@ public function __toString() : string
         $variableName = '';
         if ($this->variableName) {
             $variableName .= ($this->isReference ? '&' : '') . ($this->isVariadic ? '...' : '');
-            $variableName .= ($this->variableName ? '$' . $this->variableName : '');
+            $variableName .= '$' . $this->variableName;
         }
 
         $type = (string) $this->type;

src/DocBlock/Tags/Property.php

@@ -105,7 +105,7 @@ public function __toString() : string
         }
 
         if ($this->variableName) {
-            $variableName = ($this->variableName ? '$' . $this->variableName : '');
+            $variableName = '$' . $this->variableName;
         } else {
             $variableName = '';
         }

src/DocBlock/Tags/PropertyRead.php

@@ -105,7 +105,7 @@ public function __toString() : string
         }
 
         if ($this->variableName) {
-            $variableName = ($this->variableName ? '$' . $this->variableName : '');
+            $variableName = '$' . $this->variableName;
         } else {
             $variableName = '';
         }

src/DocBlock/Tags/PropertyWrite.php

@@ -105,7 +105,7 @@ public function __toString() : string
         }
 
         if ($this->variableName) {
-            $variableName = ($this->variableName ? '$' . $this->variableName : '');
+            $variableName = '$' . $this->variableName;
         } else {
             $variableName = '';
         }

src/DocBlock/Tags/Source.php

@@ -107,7 +107,7 @@ public function __toString() : string
         $lineCount = $this->lineCount !== null ? '' . $this->lineCount : '';
 
         return $startingLine
-            . ($lineCount !== '' ? ($startingLine !== '' ? ' ' : '') . $lineCount : '')
-            . ($description !== '' ? ($startingLine !== '' || $lineCount !== '' ? ' ' : '') . $description : '');
+            . ($lineCount !== '' ? ($startingLine || $startingLine === '0' ? ' ' : '') . $lineCount : '')
+            . ($description !== '' ? ($startingLine || $startingLine === '0' || $lineCount !== '' ? ' ' : '') . $description : '');
     }
 }

src/DocBlock/Tags/Var_.php

@@ -106,7 +106,7 @@ public function __toString() : string
         }
 
         if ($this->variableName) {
-            $variableName = ($this->variableName ? '$' . $this->variableName : '');
+            $variableName = '$' . $this->variableName;
         } else {
             $variableName = '';
         }

tests/unit/DocBlock/Tags/MethodTest.php

@@ -277,7 +277,7 @@ public function testStringRepresentationIsReturned() : void
      */
     public function testStringRepresentationIsReturnedWithoutDescription() : void
     {
-        $fixture   = new Method('myMethod', [], null, false, new Description(''));
+        $fixture = new Method('myMethod', [], null, false, new Description(''));
 
         $this->assertSame(
             'void myMethod()',