[cs] finalize, spaces, concat and strict comparison

Author: TomasVotruba

easy-coding-standard.neon

@@ -1,11 +1,31 @@
 includes:
     - temp/ecs/config/clean-code.neon
     - temp/ecs/config/psr2-checkers.neon
+    - temp/ecs/config/spaces.neon
+    - temp/ecs/config/common.neon
+
+checkers:
+    PhpCsFixer\Fixer\Operator\ConcatSpaceFixer:
+        spacing: one
 
 parameters:
+    exclude_checkers:
+        # from temp/ecs/config/common.neon
+        - PhpCsFixer\Fixer\ClassNotation\OrderedClassElementsFixer
+        - PhpCsFixer\Fixer\PhpUnit\PhpUnitStrictFixer
+        - PhpCsFixer\Fixer\ControlStructure\YodaStyleFixer
+        # from temp/ecs/config/spaces.neon
+        - PhpCsFixer\Fixer\Operator\NotOperatorWithSuccessorSpaceFixer
+
     skip:
         SlevomatCodingStandard\Sniffs\Classes\UnusedPrivateElementsSniff:
+            # WIP code
+            - src/DocBlock/StandardTagFactory.php
+        PHP_CodeSniffer\Standards\Generic\Sniffs\CodeAnalysis\EmptyStatementSniff:
+            # WIP code
             - src/DocBlock/StandardTagFactory.php
         PHP_CodeSniffer\Standards\Squiz\Sniffs\Classes\ValidClassNameSniff:
             - src/DocBlock/Tags/Return_.php
             - src/DocBlock/Tags/Var_.php
+        PHP_CodeSniffer\Standards\Generic\Sniffs\NamingConventions\CamelCapsFunctionNameSniff:
+            - */tests/**

src/DocBlock.php

@@ -174,7 +174,7 @@ public function getTagsByName($name)
 
         /** @var Tag $tag */
         foreach ($this->getTags() as $tag) {
-            if ($tag->getName() != $name) {
+            if ($tag->getName() !== $name) {
                 continue;
             }
 
@@ -197,7 +197,7 @@ public function hasTag($name)
 
         /** @var Tag $tag */
         foreach ($this->getTags() as $tag) {
-            if ($tag->getName() == $name) {
+            if ($tag->getName() === $name) {
                 return true;
             }
         }

src/DocBlock/Description.php

@@ -69,7 +69,7 @@ public function __construct($bodyTemplate, array $tags = [])
         $this->bodyTemplate = $bodyTemplate;
         $this->tags = $tags;
     }
-    
+
     /**
      * Returns the tags for this DocBlock.
      *

src/DocBlock/Tags/Param.php

@@ -77,7 +77,7 @@ public static function create(
         }
 
         // if the next item starts with a $ or ...$ it must be the variable name
-        if (isset($parts[0]) && (strlen($parts[0]) > 0) && ($parts[0][0] == '$' || substr($parts[0], 0, 4) === '...$')) {
+        if (isset($parts[0]) && (strlen($parts[0]) > 0) && ($parts[0][0] === '$' || substr($parts[0], 0, 4) === '...$')) {
             $variableName = array_shift($parts);
             array_shift($parts);
 

src/DocBlock/Tags/Property.php

@@ -70,7 +70,7 @@ public static function create(
         }
 
         // if the next item starts with a $ or ...$ it must be the variable name
-        if (isset($parts[0]) && (strlen($parts[0]) > 0) && ($parts[0][0] == '$')) {
+        if (isset($parts[0]) && (strlen($parts[0]) > 0) && ($parts[0][0] === '$')) {
             $variableName = array_shift($parts);
             array_shift($parts);
 

src/DocBlock/Tags/PropertyRead.php

@@ -70,7 +70,7 @@ public static function create(
         }
 
         // if the next item starts with a $ or ...$ it must be the variable name
-        if (isset($parts[0]) && (strlen($parts[0]) > 0) && ($parts[0][0] == '$')) {
+        if (isset($parts[0]) && (strlen($parts[0]) > 0) && ($parts[0][0] === '$')) {
             $variableName = array_shift($parts);
             array_shift($parts);
 

src/DocBlock/Tags/PropertyWrite.php

@@ -70,7 +70,7 @@ public static function create(
         }
 
         // if the next item starts with a $ or ...$ it must be the variable name
-        if (isset($parts[0]) && (strlen($parts[0]) > 0) && ($parts[0][0] == '$')) {
+        if (isset($parts[0]) && (strlen($parts[0]) > 0) && ($parts[0][0] === '$')) {
             $variableName = array_shift($parts);
             array_shift($parts);
 

src/DocBlock/Tags/Var_.php

@@ -70,7 +70,7 @@ public static function create(
         }
 
         // if the next item starts with a $ or ...$ it must be the variable name
-        if (isset($parts[0]) && (strlen($parts[0]) > 0) && ($parts[0][0] == '$')) {
+        if (isset($parts[0]) && (strlen($parts[0]) > 0) && ($parts[0][0] === '$')) {
             $variableName = array_shift($parts);
             array_shift($parts);
 
@@ -111,8 +111,8 @@ public function getType()
      */
     public function __toString()
     {
-        return ($this->type ? $this->type.' ' : '')
-            .(empty($this->variableName) ? null : ('$'.$this->variableName))
-            .($this->description ? ' '.$this->description : '');
+        return ($this->type ? $this->type . ' ' : '')
+            . (empty($this->variableName) ? null : ('$' . $this->variableName))
+            . ($this->description ? ' ' . $this->description : '');
     }
 }

src/DocBlockFactory.php

@@ -120,7 +120,7 @@ private function stripDocComment($comment)
         $comment = trim(preg_replace('#[ \t]*(?:\/\*\*|\*\/|\*)?[ \t]{0,1}(.*)?#u', '$1', $comment));
 
         // reg ex above is not able to remove */ from a single line docblock
-        if (substr($comment, -2) == '*/') {
+        if (substr($comment, -2) === '*/') {
             $comment = trim(substr($comment, 0, -2));
         }
 

tests/integration/DocblocksWithAnnotationsTest.php

@@ -27,7 +27,6 @@ public function testDocblockWithAnnotations()
      */
 DOCCOMMENT;
 
-
         $factory  = DocBlockFactory::createInstance();
         $docblock = $factory->create($docComment);