[BUGFIX] Fix the DefaultNodeRenderer for array values

Up to now when the value of a node was an array (as for nodes replace and compound) there was an empty string returned in rendering. Added handling of array values (which fixes rendering of the replace directive) and added errrors in case a node that cannot be handled by the defaultnoderenderer is passed to it.

Additionally I removed the superflous new lines in rendering of inline variables

Author: linawolf

packages/guides/resources/config/guides.php

@@ -153,6 +153,8 @@
         ->set(MenuEntryRenderer::class)
         ->tag('phpdoc.guides.noderenderer.html')
 
+        ->set(DefaultNodeRenderer::class)
+
         ->set(InMemoryNodeRendererFactory::class)
         ->args([
             '$nodeRenderers' => tagged_iterator('phpdoc.guides.noderenderer.html'),

packages/guides/resources/template/html/inline/variable.html.twig

@@ -1 +1,2 @@
-{{ renderNode(node.child) }}
+{% apply spaceless %}{{ renderNode(node.child) }}
+{% endapply %}

packages/guides/src/NodeRenderers/DefaultNodeRenderer.php

@@ -15,15 +15,21 @@
 
 use phpDocumentor\Guides\Nodes\Node;
 use phpDocumentor\Guides\RenderContext;
+use Psr\Log\LoggerInterface;
 
 use function assert;
+use function is_array;
 use function is_string;
 
 /** @implements NodeRenderer<Node> */
 class DefaultNodeRenderer implements NodeRenderer, NodeRendererFactoryAware
 {
     private NodeRendererFactory|null $nodeRendererFactory = null;
 
+    public function __construct(private readonly LoggerInterface $logger)
+    {
+    }
+
     public function setNodeRendererFactory(NodeRendererFactory $nodeRendererFactory): void
     {
         $this->nodeRendererFactory = $nodeRendererFactory;
@@ -39,10 +45,25 @@ public function render(Node $node, RenderContext $renderContext): string
             return $this->nodeRendererFactory->get($value)->render($value, $renderContext);
         }
 
+        if (is_array($value)) {
+            $returnValue = '';
+            foreach ($value as $child) {
+                if ($child instanceof Node) {
+                    $returnValue .= $this->render($child, $renderContext);
+                } else {
+                    $this->logger->error('The default renderer cannot be applied to node ' . $node::class);
+                }
+            }
+
+            return $returnValue;
+        }
+
         if (is_string($value)) {
             return $value;
         }
 
+        $this->logger->error('The default renderer cannot be applied to node ' . $node::class);
+
         return '';
     }
 

tests/Integration/tests/variables-from-project/expected/index.html

@@ -8,9 +8,7 @@
     <div class="section" id="some-document">
     <h1>Some Document</h1>
 
-            <p>Project My Project
- in version 3.14
-</p>
+            <p>Project My Project in version 3.14</p>
     </div>
 
 </body>

tests/Integration/tests/variables-replace/expected/index.html

@@ -8,8 +8,7 @@
     <div class="section" id="document-title">
     <h1>Document Title</h1>
 
-            <p>We are using ReStructuredText
- here.</p>
+            <p>We are using ReStructuredText here.</p>
     </div>
 
 </body>