Merge pull request #508 from phpDocumentor/bugfix/variable_version

linawolf · web-flow · commit a9c90a9e6773 · 2023-07-28T12:21:45.000+02:00
[BUGFIX] Ensure variables version and project always contain the info…
diff --git a/packages/guides/src/Nodes/ProjectNode.php b/packages/guides/src/Nodes/ProjectNode.php
@@ -55,6 +55,8 @@ public function getVersion(): string|null
 
     public function setVersion(string $version): void
     {
+        $this->addVariable('version', new PlainTextInlineNode($version));
+        $this->addVariable('release', new PlainTextInlineNode($version));
         $this->version = $version;
     }
 
@@ -65,6 +67,7 @@ public function getTitle(): string|null
 
     public function setTitle(string $title): void
     {
+        $this->addVariable('project', new PlainTextInlineNode($title));
         $this->title = $title;
     }
 
diff --git a/tests/Integration/tests/variables-from-project/expected/index.html b/tests/Integration/tests/variables-from-project/expected/index.html
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <title>Some Document - My Project</title>
+
+</head>
+<body>
+    <div class="section" id="some-document">
+    <h1>Some Document</h1>
+
+            <p>Project My Project
+ in version 3.14
+</p>
+    </div>
+
+</body>
+</html>
diff --git a/tests/Integration/tests/variables-from-project/input/index.rst b/tests/Integration/tests/variables-from-project/input/index.rst
@@ -0,0 +1,9 @@
+:project:
+    My Project
+:version:
+    3.14
+
+Some Document
+=============
+
+Project |project| in version |version|

Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,8 @@ public function getVersion(): string\|null`
`55`	`55`
`56`	`56`	`public function setVersion(string $version): void`
`57`	`57`	`{`
	`58`	`+ $this->addVariable('version', new PlainTextInlineNode($version));`
	`59`	`+ $this->addVariable('release', new PlainTextInlineNode($version));`
`58`	`60`	`$this->version = $version;`
`59`	`61`	`}`
`60`	`62`
`@@ -65,6 +67,7 @@ public function getTitle(): string\|null`
`65`	`67`
`66`	`68`	`public function setTitle(string $title): void`
`67`	`69`	`{`
	`70`	`+ $this->addVariable('project', new PlainTextInlineNode($title));`
`68`	`71`	`$this->title = $title;`
`69`	`72`	`}`
`70`	`73`