[TASK] Have a clone of the Textrole factory in the DocumentParserContext

Author: linawolf

packages/guides-restructured-text/src/RestructuredText/MarkupLanguageParser.php

@@ -10,6 +10,7 @@
 use phpDocumentor\Guides\ParserContext;
 use phpDocumentor\Guides\RestructuredText\Parser\DocumentParserContext;
 use phpDocumentor\Guides\RestructuredText\Parser\Productions\Rule;
+use phpDocumentor\Guides\RestructuredText\TextRoles\TextRoleFactory;
 use RuntimeException;
 use Webmozart\Assert\Assert;
 
@@ -26,6 +27,7 @@ class MarkupLanguageParser implements ParserInterface
     /** @param Rule<DocumentNode> $startingRule */
     public function __construct(
         private readonly Rule $startingRule,
+        private readonly TextRoleFactory $textRoleFactory,
     ) {
     }
 
@@ -39,6 +41,7 @@ public function getSubParser(): MarkupLanguageParser
     {
         return new MarkupLanguageParser(
             $this->startingRule,
+            $this->textRoleFactory,
         );
     }
 
@@ -74,6 +77,7 @@ public function parse(ParserContext $parserContext, string $contents): DocumentN
         $this->documentParser = new DocumentParserContext(
             $contents,
             $parserContext,
+            $this->textRoleFactory,
             $this,
         );
 

packages/guides-restructured-text/src/RestructuredText/Parser/DocumentParserContext.php

@@ -17,6 +17,7 @@
 use phpDocumentor\Guides\Nodes\ProjectNode;
 use phpDocumentor\Guides\ParserContext;
 use phpDocumentor\Guides\RestructuredText\MarkupLanguageParser;
+use phpDocumentor\Guides\RestructuredText\TextRoles\TextRoleFactory;
 use RuntimeException;
 
 /**
@@ -31,16 +32,21 @@ class DocumentParserContext
 
     private LinesIterator $documentIterator;
     private int $currentTitleLevel;
+    /* Each Document has its own text role factory as text roles can be changed on a per document base
+        by directives */
+    private TextRoleFactory $textRoleFactoryForDocument;
 
     /** @var string[] */
     private array $titleLetters = [];
 
     public function __construct(
         string $content,
         private readonly ParserContext $context,
+        TextRoleFactory $textRoleFactory,
         private readonly MarkupLanguageParser $markupLanguageParser,
     ) {
         $this->documentIterator = new LinesIterator();
+        $this->textRoleFactoryForDocument = clone $textRoleFactory;
         $this->documentIterator->load($content);
         $this->currentTitleLevel = $context->getInitialHeaderLevel() - 1;
     }
@@ -115,4 +121,9 @@ public function withContentsPreserveSpace(string $contents): self
 
         return $that;
     }
+
+    public function getTextRoleFactoryForDocument(): TextRoleFactory
+    {
+        return $this->textRoleFactoryForDocument;
+    }
 }

packages/guides-restructured-text/tests/unit/Parser/Productions/RuleTestCase.php

@@ -13,6 +13,7 @@
 use phpDocumentor\Guides\RestructuredText\Parser\DocumentParserContext;
 use phpDocumentor\Guides\RestructuredText\Parser\InlineParser;
 use phpDocumentor\Guides\RestructuredText\Parser\LinesIterator;
+use phpDocumentor\Guides\RestructuredText\TextRoles\TextRoleFactory;
 use phpDocumentor\Guides\UrlGenerator;
 use PHPUnit\Framework\TestCase;
 
@@ -43,6 +44,7 @@ protected function createContext(string $input): DocumentParserContext
                 $this->createStub(FilesystemInterface::class),
                 new UrlGenerator(),
             ),
+            $this->createStub(TextRoleFactory::class),
             $this->createStub(MarkupLanguageParser::class),
         );
     }

packages/guides-restructured-text/tests/unit/Parser/Productions/SectionRuleTest.php

@@ -23,6 +23,7 @@
 use phpDocumentor\Guides\RestructuredText\MarkupLanguageParser;
 use phpDocumentor\Guides\RestructuredText\Parser\DocumentParserContext;
 use phpDocumentor\Guides\RestructuredText\Parser\InlineParser;
+use phpDocumentor\Guides\RestructuredText\TextRoles\TextRoleFactory;
 use phpDocumentor\Guides\UrlGeneratorInterface;
 
 final class SectionRuleTest extends RuleTestCase
@@ -200,6 +201,7 @@ private function getDocumentParserContext(string $content): DocumentParserContex
         return new DocumentParserContext(
             $content,
             $parserContext,
+            $this->createStub(TextRoleFactory::class),
             $this->createStub(MarkupLanguageParser::class),
         );
     }