Find does not auto-highlight single-character search terms

[gugray]

Nature of issue?

• Found a bug

Details about the bug:

• Web browser and version: 88.0.1 (64-bit)
• Operating System: Windows 10

Steps to reproduce

For both scenarios, have a sketch open with some content in it. Ideally the sketch has just been opened, so the options in the Find dialog have their default state: not a regex, not case sensitive, not "only whole words".

Scenario 1:

• Select at least two letters of a token. Make sure it is a string that occurs elsewhere in the sketch too.
• Press Ctrl+F to open Find
  Result: All occurrences of the selected text are highlighted. Great.
• Close Find
• Select a single letter in the editor. Make sure it occurs elsewhere in the sketch too.
• Press Ctrl+F to open Find
  Actual result: Nothing is highlighted.
  Expected result: All occurrences of the single letter are highlighted in the sketch.
• In the open Find dialog, where the input field now has the focus, press Enter
  Result: Now, but only now, all occurrences are highlighed, and Find cycles through them.

Scenario 2:

• With no selection in the editor, press Ctrl+F to bring up Find. Its input field is empty.
• Type a single character. Make sure it occurs in the sketch.
  Actual result: Nothing happens.
  Expected result: All occurrences of the single-character search term are highlighted.
• Type an additional character. Make sure the string occurs in the sketch.
  Result: Now, but only now, all occurrences are highlighed, and Find cycles through them.

Related: when I have a longer string in the input field of Find and I delete the last character, the occurrences in the editor are updated. When I have a two-character string and I delete the second character, the occurrences are neither updated, nor are they removed. This is confusing behavior because the highlights are now inconsistent with the state of the Find dialog.

Attaching screen grabs.

no-autofind-scenario-1.mp4

no-autofind-scenario-2.mp4

[gugray]

I have a vague suspicion that this behavior may be partially intended. I can imagine that auto-highlighting single-character search terms might be a performance issue.

If that's the case, I would still give it further thought:

• At the very least, the behavior is confusing when I delete characters from the input field, and highlights don't get updated with only a single-character search term is left.
• Is the assumed performance issue real? At what document sizes?