Implement .length property on strings and arrays

phug-php/phug#25

Author: kylekatarnls

examples/length.js

@@ -0,0 +1,9 @@
+a = [];
+b = 'bb';
+
+c = [
+    a.length,
+    b.length
+];
+
+return c.join(',');

examples/length.return

@@ -0,0 +1 @@
+0,2

src/JsPhpize/Compiler/Helpers/Dot.h

@@ -20,6 +20,9 @@ function ($base) {
             if (preg_match('/^[-+]?\d+$/', strval($key))) {
                 return substr($base, intval($key), 1);
             }
+            if ($key === 'length') {
+                return strlen($base);
+            }
             if ($key === 'substr' || $key === 'slice') {
                 return function ($start, $length = null) use ($base) {
                     return func_num_args() === 1 ? substr($base, $start) : substr($base, $start, $length);

src/JsPhpize/Compiler/Helpers/DotObject.h

@@ -20,6 +20,9 @@ function ($base) {
             if (preg_match('/^[-+]?\d+$/', strval($key))) {
                 return substr($base, intval($key), 1);
             }
+            if ($key === 'length') {
+                return strlen($base);
+            }
             if ($key === 'substr' || $key === 'slice') {
                 return function ($start, $length = null) use ($base) {
                     return func_num_args() === 1 ? substr($base, $start) : substr($base, $start, $length);

src/JsPhpize/Compiler/Helpers/DotWithArrayPrototype.h

@@ -1,5 +1,8 @@
 function ($base) {
     $arrayPrototype = function ($base, $key) {
+        if ($key === 'length') {
+            return count($base);
+        }
         if ($key === 'forEach') {
             return function ($callback, $userData = null) use (&$base) {
                 return array_walk($base, $callback, $userData);
@@ -96,6 +99,9 @@ function ($base) {
             if (preg_match('/^[-+]?\d+$/', strval($key))) {
                 return substr($base, intval($key), 1);
             }
+            if ($key === 'length') {
+                return strlen($base);
+            }
             if ($key === 'substr' || $key === 'slice') {
                 return function ($start, $length = null) use ($base) {
                     return func_num_args() === 1 ? substr($base, $start) : substr($base, $start, $length);

tests/render.php

@@ -26,7 +26,11 @@ public function caseProvider()
     public function testJsPhpizeGeneration($returnFile, $jsFile)
     {
         $examples = __DIR__ . '/../examples';
-        $jsPhpize = new JsPhpize();
+        $jsPhpize = new JsPhpize([
+            'helpers' => [
+                'dot' => 'dotWithArrayPrototype',
+            ],
+        ]);
         $expected = file_get_contents($examples . '/' . $returnFile);
 
         try {