From 49727fb23646f0c97d20cfc56effba0a43eee693 Mon Sep 17 00:00:00 2001 From: Sriram Bharadwaj Date: Thu, 25 Dec 2025 18:31:31 +0530 Subject: [PATCH 1/4] Fix Ninja build error: explicit glob for Vulkan shaders --- backends/vulkan/cmake/ShaderLibrary.cmake | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/backends/vulkan/cmake/ShaderLibrary.cmake b/backends/vulkan/cmake/ShaderLibrary.cmake index 3d4db89ac14..47e954ce401 100644 --- a/backends/vulkan/cmake/ShaderLibrary.cmake +++ b/backends/vulkan/cmake/ShaderLibrary.cmake @@ -60,6 +60,9 @@ function(gen_vulkan_shader_lib_cpp shaders_path) ) endif() + # Ninja cannot expand wildcards (*) in DEPENDS lists. + file(GLOB VULKAN_SHADERS "${shaders_path}/*.glsl") + add_custom_command( COMMENT "Generating Vulkan Compute Shaders" OUTPUT ${VULKAN_SHADERGEN_OUT_PATH}/spv.cpp @@ -70,7 +73,7 @@ function(gen_vulkan_shader_lib_cpp shaders_path) --glslc-path=${GLSLC_PATH} --tmp-dir-path=${VULKAN_SHADERGEN_OUT_PATH}/shader_cache/ --env ${VULKAN_GEN_ARG_ENV} ${GEN_SPV_ARGS} - DEPENDS ${shaders_path}/* + DEPENDS ${VULKAN_SHADERS} ${EXECUTORCH_ROOT}/backends/vulkan/runtime/gen_vulkan_spv.py ) From 9e065b44a5353a04787b55b72ce9cccd4673b035 Mon Sep 17 00:00:00 2001 From: Sriram Bharadwaj Date: Thu, 25 Dec 2025 19:20:18 +0530 Subject: [PATCH 2/4] trigger ci From bba15826922b5f9c01f1b8cc60f926fad2b8cb74 Mon Sep 17 00:00:00 2001 From: Sriram Bharadwaj Date: Thu, 25 Dec 2025 20:07:38 +0530 Subject: [PATCH 3/4] chore: trigger lintrunner check From b2ddd6869c61fc11b9e2a86721e6eb761eaf7819 Mon Sep 17 00:00:00 2001 From: Sriram Bharadwaj Date: Tue, 30 Dec 2025 00:57:58 +0530 Subject: [PATCH 4/4] fix: modified vulkan shaders glob pattern to be exhaustive --- backends/vulkan/cmake/ShaderLibrary.cmake | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/backends/vulkan/cmake/ShaderLibrary.cmake b/backends/vulkan/cmake/ShaderLibrary.cmake index 47e954ce401..f1e1d8ac53f 100644 --- a/backends/vulkan/cmake/ShaderLibrary.cmake +++ b/backends/vulkan/cmake/ShaderLibrary.cmake @@ -61,7 +61,12 @@ function(gen_vulkan_shader_lib_cpp shaders_path) endif() # Ninja cannot expand wildcards (*) in DEPENDS lists. - file(GLOB VULKAN_SHADERS "${shaders_path}/*.glsl") + file(GLOB VULKAN_SHADERS + "${shaders_path}/*.glsl" + "${shaders_path}/*.glslh" + "${shaders_path}/*.yaml" + "${shaders_path}/*.h" + ) add_custom_command( COMMENT "Generating Vulkan Compute Shaders"