Skip to content

Commit be37878

Browse files
authored
refactor: upgrade eslint (#756)
* refactor: upgrade eslint * test: add tests to lint
1 parent 1742abe commit be37878

File tree

8 files changed

+438
-409
lines changed

8 files changed

+438
-409
lines changed

.eslintrc

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,32 @@
11
{
22
"parser": "@typescript-eslint/parser",
3+
"plugins": ["@typescript-eslint"],
34
"extends": [
45
"standard",
56
"standard-react",
67
"plugin:prettier/recommended",
7-
"prettier/standard",
8-
"prettier/react",
98
"plugin:@typescript-eslint/eslint-recommended"
109
],
1110
"env": {
12-
"node": true
11+
"browser": true
1312
},
1413
"parserOptions": {
15-
"ecmaVersion": 2020,
14+
"ecmaVersion": "latest",
1615
"ecmaFeatures": {
17-
"legacyDecorators": true,
1816
"jsx": true
1917
}
2018
},
2119
"settings": {
2220
"react": {
23-
"version": "16"
21+
"version": "detect"
2422
}
2523
},
2624
"rules": {
2725
"curly": [2, "multi-line"],
2826
"quotes": [2, "single", "avoid-escape"],
2927
"react/display-name": 0,
3028
"react/jsx-boolean-value": 1,
31-
"jsx-quotes": 1,
29+
"jsx-quotes": [1, "prefer-single"],
3230
"react/jsx-no-undef": 1,
3331
"react/jsx-sort-props": 0,
3432
"react/jsx-uses-react": 1,
@@ -40,6 +38,8 @@
4038
"react/react-in-jsx-scope": 1,
4139
"react/self-closing-comp": 1,
4240
"semi": [2, "always"],
43-
"strict": 0
41+
"strict": 0,
42+
"no-use-before-define": 0,
43+
"@typescript-eslint/no-use-before-define": 2
4444
}
4545
}

.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
lts/*

.prettierrc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
"semi": true,
55
"tabWidth": 2,
66
"bracketSpacing": true,
7-
"jsxBracketSameLine": false,
87
"arrowParens": "avoid",
98
"trailingComma": "es5"
109
}

package.json

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"prepublishOnly": "yarn build",
3131
"test": "yarn test:unit && yarn test:lint && yarn test:build",
3232
"test:build": "yarn build",
33-
"test:lint": "eslint src/**/*.{ts,tsx}",
33+
"test:lint": "eslint 'src/**/*.{ts,tsx}' 'test/**/*.{ts,tsx}'",
3434
"test:unit": "jest -c jest.config.json",
3535
"format": "prettier --write src",
3636
"predeploy": "cd example && yarn && yarn build",
@@ -51,28 +51,28 @@
5151
"@types/jest": "^27.0.2",
5252
"@types/lodash": "^4.14.150",
5353
"@types/react": "^17.0.28",
54-
"@typescript-eslint/eslint-plugin": "^2.26.0",
55-
"@typescript-eslint/parser": "^2.26.0",
54+
"@typescript-eslint/eslint-plugin": "^5.0.0",
55+
"@typescript-eslint/parser": "^5.0.0",
5656
"babel-eslint": "^10.0.3",
5757
"chart.js": "^3.1.0",
58-
"eslint": "^6.8.0",
59-
"eslint-config-prettier": "^6.7.0",
60-
"eslint-config-standard": "^14.1.0",
61-
"eslint-config-standard-react": "^9.2.0",
62-
"eslint-plugin-import": "^2.18.2",
58+
"eslint": "^7.32.0",
59+
"eslint-config-prettier": "^8.3.0",
60+
"eslint-config-standard": "^16.0.3",
61+
"eslint-config-standard-react": "^11.0.1",
62+
"eslint-plugin-import": "^2.25.1",
6363
"eslint-plugin-node": "^11.0.0",
64-
"eslint-plugin-prettier": "^3.1.1",
65-
"eslint-plugin-promise": "^4.2.1",
64+
"eslint-plugin-prettier": "^4.0.0",
65+
"eslint-plugin-promise": "^5.1.0",
6666
"eslint-plugin-react": "^7.17.0",
67-
"eslint-plugin-standard": "^5.0.0",
6867
"gh-pages": "^3.2.3",
6968
"jest": "^27.2.5",
7069
"jest-canvas-mock": "^2.2.0",
7170
"microbundle-crl": "^0.13.11",
7271
"prettier": "^2.0.4",
7372
"react": "^17.0.1",
7473
"react-dom": "^17.0.1",
75-
"react-test-renderer": "^17.0.1"
74+
"react-test-renderer": "^17.0.1",
75+
"typescript": "^4.4.3"
7676
},
7777
"files": [
7878
"dist"

src/chart.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,9 @@ import React, {
66
useMemo,
77
forwardRef,
88
} from 'react';
9-
// eslint-disable-next-line no-unused-vars
109
import { Props } from './types';
1110

1211
import Chart from 'chart.js/auto';
13-
// eslint-disable-next-line no-unused-vars
1412
import type { ChartData } from 'chart.js';
1513

1614
import merge from 'lodash/merge';

src/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import React, { forwardRef } from 'react';
2-
// eslint-disable-next-line no-unused-vars
32
import { Props } from './types';
43
import ChartComponent from './chart';
54
import Chart from 'chart.js/auto';

src/types.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line no-unused-vars
21
import Chart from './index';
32

43
export interface Props extends React.CanvasHTMLAttributes<HTMLCanvasElement> {

0 commit comments

Comments
 (0)