From 023795ec7ece4d86b207308b201958e3890871af Mon Sep 17 00:00:00 2001 From: Shubham Patra Date: Thu, 27 Nov 2025 21:34:48 +0530 Subject: [PATCH 1/4] refactor: remove debug console logs and improve TypeScript types - Remove build-time console.log statements from compileMDX.ts - Replace 'any' type with proper ReturnType in usePendingRoute.ts - Improves code quality and type safety --- src/hooks/usePendingRoute.ts | 2 +- src/utils/compileMDX.ts | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/src/hooks/usePendingRoute.ts b/src/hooks/usePendingRoute.ts index 17d7525b4f8..7c27d74a0fb 100644 --- a/src/hooks/usePendingRoute.ts +++ b/src/hooks/usePendingRoute.ts @@ -17,7 +17,7 @@ const usePendingRoute = () => { const [pendingRoute, setPendingRoute] = useState(null); const currentRoute = useRef(null); useEffect(() => { - let routeTransitionTimer: any = null; + let routeTransitionTimer: ReturnType | undefined = undefined; const handleRouteChangeStart = (url: string) => { clearTimeout(routeTransitionTimer); diff --git a/src/utils/compileMDX.ts b/src/utils/compileMDX.ts index c312f03fe96..dae32da9153 100644 --- a/src/utils/compileMDX.ts +++ b/src/utils/compileMDX.ts @@ -45,16 +45,8 @@ export default async function compileMDX( ); const cached = await store.get(hash); if (cached) { - console.log( - 'Reading compiled MDX for /' + path + ' from ./node_modules/.cache/' - ); return cached; } - if (process.env.NODE_ENV === 'production') { - console.log( - 'Cache miss for MDX for /' + path + ' from ./node_modules/.cache/' - ); - } // If we don't add these fake imports, the MDX compiler // will insert a bunch of opaque components we can't introspect. From 5a85b7c97ee78966486fd0b65e0dd6e4be29843e Mon Sep 17 00:00:00 2001 From: Shubham Patra Date: Thu, 27 Nov 2025 21:43:31 +0530 Subject: [PATCH 2/4] chore: bump DISK_CACHE_BREAKER after compileMDX changes --- src/utils/compileMDX.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/compileMDX.ts b/src/utils/compileMDX.ts index dae32da9153..5968f1113c6 100644 --- a/src/utils/compileMDX.ts +++ b/src/utils/compileMDX.ts @@ -10,7 +10,7 @@ import {MDXComponents} from 'components/MDX/MDXComponents'; // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ // ~~~~ IMPORTANT: BUMP THIS IF YOU CHANGE ANY CODE BELOW ~~~ -const DISK_CACHE_BREAKER = 11; +const DISK_CACHE_BREAKER = 12; // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ export default async function compileMDX( From e987dc22f9265ce92c7cfa59a5eded71b31ba9ce Mon Sep 17 00:00:00 2001 From: Shubham Patra Date: Thu, 27 Nov 2025 22:00:55 +0530 Subject: [PATCH 3/4] style: apply prettier formatting to usePendingRoute.ts --- src/hooks/usePendingRoute.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/hooks/usePendingRoute.ts b/src/hooks/usePendingRoute.ts index 7c27d74a0fb..4dda25087d1 100644 --- a/src/hooks/usePendingRoute.ts +++ b/src/hooks/usePendingRoute.ts @@ -17,7 +17,8 @@ const usePendingRoute = () => { const [pendingRoute, setPendingRoute] = useState(null); const currentRoute = useRef(null); useEffect(() => { - let routeTransitionTimer: ReturnType | undefined = undefined; + let routeTransitionTimer: ReturnType | undefined = + undefined; const handleRouteChangeStart = (url: string) => { clearTimeout(routeTransitionTimer); From ceed92918abf5e74f913826971976b52100dc0a5 Mon Sep 17 00:00:00 2001 From: Shubham Patra Date: Thu, 27 Nov 2025 22:08:16 +0530 Subject: [PATCH 4/4] fix: use NodeJS.Timeout type and add undefined checks --- src/hooks/usePendingRoute.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/hooks/usePendingRoute.ts b/src/hooks/usePendingRoute.ts index 4dda25087d1..682a84a308c 100644 --- a/src/hooks/usePendingRoute.ts +++ b/src/hooks/usePendingRoute.ts @@ -17,11 +17,10 @@ const usePendingRoute = () => { const [pendingRoute, setPendingRoute] = useState(null); const currentRoute = useRef(null); useEffect(() => { - let routeTransitionTimer: ReturnType | undefined = - undefined; + let routeTransitionTimer: NodeJS.Timeout | undefined = undefined; const handleRouteChangeStart = (url: string) => { - clearTimeout(routeTransitionTimer); + if (routeTransitionTimer) clearTimeout(routeTransitionTimer); routeTransitionTimer = setTimeout(() => { if (currentRoute.current !== url) { currentRoute.current = url; @@ -31,7 +30,7 @@ const usePendingRoute = () => { }; const handleRouteChangeComplete = () => { setPendingRoute(null); - clearTimeout(routeTransitionTimer); + if (routeTransitionTimer) clearTimeout(routeTransitionTimer); }; events.on('routeChangeStart', handleRouteChangeStart); events.on('routeChangeComplete', handleRouteChangeComplete); @@ -39,7 +38,7 @@ const usePendingRoute = () => { return () => { events.off('routeChangeStart', handleRouteChangeStart); events.off('routeChangeComplete', handleRouteChangeComplete); - clearTimeout(routeTransitionTimer); + if (routeTransitionTimer) clearTimeout(routeTransitionTimer); }; }, [events]);