BETTER COMBOBOX (#306)

Author: pierry01

lib/ruby_ui/combobox/combobox.rb

@@ -2,7 +2,7 @@
 
 module RubyUI
   class Combobox < Base
-    def initialize(term: "items", **)
+    def initialize(term: nil, **)
       @term = term
       super(**)
     end
@@ -18,7 +18,8 @@ def default_attrs
         role: "combobox",
         data: {
           controller: "ruby-ui--combobox",
-          ruby_ui__combobox_term_value: @term.to_s
+          ruby_ui__combobox_term_value: @term,
+          action: "turbo:morph@window->ruby-ui--combobox#updateTriggerContent"
         }
       }
     end

lib/ruby_ui/combobox/combobox_controller.js

@@ -53,12 +53,12 @@ export default class extends Controller {
   updateTriggerContent() {
     const checkedInputs = this.inputTargets.filter(input => input.checked)
 
-    if (checkedInputs.length == 0) {
+    if (checkedInputs.length === 0) {
       this.triggerContentTarget.innerText = this.triggerTarget.dataset.placeholder
-    } else if (checkedInputs.length === 1) {
-      this.triggerContentTarget.innerText = this.inputContent(checkedInputs[0])
-    } else {
+    } else if (this.termValue && checkedInputs.length > 1) {
       this.triggerContentTarget.innerText = `${checkedInputs.length} ${this.termValue}`
+    } else {
+      this.triggerContentTarget.innerText = checkedInputs.map((input) => this.inputContent(input)).join(", ")
     }
   }