Skip to content

Make Dialog use <dialog>? #343

@janpeterka

Description

@janpeterka

I recently added Dialog component to my project, and I found out that it's internally div, not dialog.
Using dialog would be nice as it would make the component work without javascript (at least for new browsers with command and closedby support), and also support closing with Esc (which is currently missing).

I was also reading this for how to implement nice Dialog component, so that might be a good source.

Is there some reason not to?

I might be able to write some first version of this proposed component for further discussion, I just wanted to make sure it would be welcomed :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions