fix: fix file upload prefix bug

Author: saddamrushowl

middlewares/file-upload/uploadImage.middleware.js

@@ -6,13 +6,7 @@ const getImageExtension = require('../../utils/getImageExtension');
 // Configuring and validating the upload
 const storage = multer.diskStorage({
   destination: (req, file, callbackFunction) => {
-    const { isUserImg } = req.body;
-
-    if (file?.fieldname === 'profileImage') {
-      callbackFunction(null, 'public/uploads/users');
-    } else {
-      callbackFunction(null, 'public/uploads');
-    }
+    callbackFunction(null, 'public/uploads');
   },
 
   // By default, multer removes file extensions so let's add them back

middlewares/file-upload/userImage.middleware.js

@@ -0,0 +1,24 @@
+const multer = require('multer');
+
+const getImageExtension = require('../../utils/getImageExtension');
+
+// Set Storage Engine
+// Configuring and validating the upload
+const storage = multer.diskStorage({
+  destination: (req, file, callbackFunction) => {
+    callbackFunction(null, 'public/uploads/users');
+  },
+
+  // By default, multer removes file extensions so let's add them back
+  filename: (req, file, callbackFunction) => {
+    callbackFunction(null, `${file.fieldname}-${Date.now()}${getImageExtension(file.mimetype)}`);
+  }
+});
+
+// Initialize upload variable
+exports.uploadImage = multer({
+  storage: storage,
+  limits: {
+    fileSize: 1024 * 1024 * 10 // accept files up 10 mgb
+  }
+});

public/uploads/profileImage-1652605162107.jpeg

@@ -202,7 +202,7 @@ exports.updateUser = async (req, res, next) => {
     user.nationality = nationality || user.nationality;
     user.address = address || user.address;
     user.favoriteAnimal = favoriteAnimal || user.favoriteAnimal;
-    user.profileImage = req.file.filename ? `/static/uploads/users/${req.file.filename}` : user.profileImage;
+    user.profileImage = req.file.filename ? `/static/uploads/${req.file.filename}` : user.profileImage;
 
     const updatedUser = await user.save();
 

public/uploads/profileImage-1652605541652.png

@@ -16,7 +16,6 @@ const { WEBSITE_URL, API_VERSION, CLIENT_URL } = require('../configs/environment
  */
 
 exports.signup = async (req, res, next) => {
-  console.log("error")
   const {
     firstName,
     lastName,
@@ -49,8 +48,6 @@ exports.signup = async (req, res, next) => {
     return responseObject;
   }
 
-
-  // req.file.filename ? `/static/uploads/users/${req.file.filename}` : user.profileImage;
   const newUser = new User({
     _id: new mongoose.Types.ObjectId(),
     firstName,
@@ -63,10 +60,9 @@ exports.signup = async (req, res, next) => {
     cart,
     role,
     acceptTerms,
-    profileImage: `/static/uploads/users/${req.file.filename}`
+    profileImage: `/static/uploads/${req.file.filename}`
   });
 
-  console.log(' newUser', newUser);
   try {
     const user = await newUser.save();
     let token = await new Token({ userId: user._id });
@@ -539,7 +535,7 @@ exports.updateUser = async (req, res, next) => {
     user.nationality = nationality || user.nationality;
     user.address = address || user.address;
     user.favoriteAnimal = favoriteAnimal || user.favoriteAnimal;
-    user.profileImage = req.file.filename ? `/static/uploads/users/${req.file.filename}` : user.profileImage;
+    user.profileImage = req.file.filename ? `/static/uploads/${req.file.filename}` : user.profileImage;
 
     const updatedUser = await user.save();