From 1ac1e12a858fc0904928e872af39f58155afe365 Mon Sep 17 00:00:00 2001 From: rhit-silkaijr Date: Mon, 27 Oct 2025 20:54:05 -0400 Subject: [PATCH 01/15] Testing updated golangci version --- .github/workflows/push.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml index 818b304..31ca460 100644 --- a/.github/workflows/push.yaml +++ b/.github/workflows/push.yaml @@ -56,7 +56,7 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@v2 with: - version: v1.55.2 + version: v1.61.0 skip-pkg-cache: true skip-build-cache: true From e08c97b3b50e88f2f7bb09e87575adfd25d5bef6 Mon Sep 17 00:00:00 2001 From: rhit-silkaijr Date: Mon, 27 Oct 2025 21:07:50 -0400 Subject: [PATCH 02/15] removing typecheck --- .github/workflows/push.yaml | 2 +- .golangci.yml | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml index 31ca460..818b304 100644 --- a/.github/workflows/push.yaml +++ b/.github/workflows/push.yaml @@ -56,7 +56,7 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@v2 with: - version: v1.61.0 + version: v1.55.2 skip-pkg-cache: true skip-build-cache: true diff --git a/.golangci.yml b/.golangci.yml index a831514..fb64348 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -42,7 +42,6 @@ linters: - govet - ineffassign - staticcheck - - typecheck - unused - bidichk - contextcheck From 85807ec84521cc12c1695189ff151eee582aa960 Mon Sep 17 00:00:00 2001 From: rhit-silkaijr Date: Mon, 27 Oct 2025 21:12:43 -0400 Subject: [PATCH 03/15] Further removing checks + v1.61 --- .github/workflows/push.yaml | 2 +- .golangci.yml | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml index 818b304..31ca460 100644 --- a/.github/workflows/push.yaml +++ b/.github/workflows/push.yaml @@ -56,7 +56,7 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@v2 with: - version: v1.55.2 + version: v1.61.0 skip-pkg-cache: true skip-build-cache: true diff --git a/.golangci.yml b/.golangci.yml index fb64348..ec50ebf 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -41,7 +41,6 @@ linters: - gosimple - govet - ineffassign - - staticcheck - unused - bidichk - contextcheck From c95535d3145e95b7611bbb734925e5bcba103b4c Mon Sep 17 00:00:00 2001 From: rhit-silkaijr Date: Mon, 27 Oct 2025 21:23:24 -0400 Subject: [PATCH 04/15] Testing downgrade --- .github/workflows/push.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml index 31ca460..ab751e6 100644 --- a/.github/workflows/push.yaml +++ b/.github/workflows/push.yaml @@ -56,9 +56,9 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@v2 with: - version: v1.61.0 - skip-pkg-cache: true - skip-build-cache: true + version: v1.51.2 + skip-pkg-cache: false + skip-build-cache: false test: name: Test From 5d33bf316a82ad8c3b9373577fd374e7076eceab Mon Sep 17 00:00:00 2001 From: rhit-silkaijr Date: Mon, 27 Oct 2025 21:26:25 -0400 Subject: [PATCH 05/15] Undoing downgrade --- .github/workflows/push.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml index ab751e6..738d714 100644 --- a/.github/workflows/push.yaml +++ b/.github/workflows/push.yaml @@ -56,7 +56,7 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@v2 with: - version: v1.51.2 + version: v1.55.2 skip-pkg-cache: false skip-build-cache: false From bd5553374b4c731581c8ce2e1d7e673b36b5b411 Mon Sep 17 00:00:00 2001 From: rhit-silkaijr Date: Mon, 27 Oct 2025 21:30:10 -0400 Subject: [PATCH 06/15] Testing newest version --- .github/workflows/push.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml index 738d714..237e988 100644 --- a/.github/workflows/push.yaml +++ b/.github/workflows/push.yaml @@ -56,9 +56,9 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@v2 with: - version: v1.55.2 - skip-pkg-cache: false - skip-build-cache: false + version: v2.5.0 + skip-pkg-cache: true + skip-build-cache: true test: name: Test From b16bac7ab8d92b66f68aaa5060d61a470303fc2a Mon Sep 17 00:00:00 2001 From: rhit-silkaijr Date: Mon, 27 Oct 2025 21:32:59 -0400 Subject: [PATCH 07/15] Testing newest v1 --- .github/workflows/push.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml index 237e988..d7f10f7 100644 --- a/.github/workflows/push.yaml +++ b/.github/workflows/push.yaml @@ -56,7 +56,7 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@v2 with: - version: v2.5.0 + version: v1.64.8 skip-pkg-cache: true skip-build-cache: true From 27d603fa6c7c5cd39d55d5fbeaddceaaa1028c54 Mon Sep 17 00:00:00 2001 From: rhit-silkaijr Date: Mon, 27 Oct 2025 21:37:48 -0400 Subject: [PATCH 08/15] testing v1.62.0 --- .github/workflows/push.yaml | 2 +- .golangci.yml | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml index d7f10f7..1d9c8b7 100644 --- a/.github/workflows/push.yaml +++ b/.github/workflows/push.yaml @@ -56,7 +56,7 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@v2 with: - version: v1.64.8 + version: v1.60.2 skip-pkg-cache: true skip-build-cache: true diff --git a/.golangci.yml b/.golangci.yml index ec50ebf..a831514 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -41,6 +41,8 @@ linters: - gosimple - govet - ineffassign + - staticcheck + - typecheck - unused - bidichk - contextcheck From 020e604a1e95b1ea417c9eba305a09d75e065dc0 Mon Sep 17 00:00:00 2001 From: rhit-silkaijr Date: Mon, 27 Oct 2025 21:41:45 -0400 Subject: [PATCH 09/15] Checking if highest version works still --- .github/workflows/push.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml index 1d9c8b7..d7f10f7 100644 --- a/.github/workflows/push.yaml +++ b/.github/workflows/push.yaml @@ -56,7 +56,7 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@v2 with: - version: v1.60.2 + version: v1.64.8 skip-pkg-cache: true skip-build-cache: true From 71e93252cc1431c43bf0b4fcfdcfdaf0ac126f8e Mon Sep 17 00:00:00 2001 From: rhit-silkaijr Date: Mon, 27 Oct 2025 21:45:05 -0400 Subject: [PATCH 10/15] v1.64.2 test --- .github/workflows/push.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml index d7f10f7..06ce57b 100644 --- a/.github/workflows/push.yaml +++ b/.github/workflows/push.yaml @@ -56,7 +56,7 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@v2 with: - version: v1.64.8 + version: v1.64.2 skip-pkg-cache: true skip-build-cache: true From ffa10a0bc2a40bb81442e5c0277733f0bb3d52ac Mon Sep 17 00:00:00 2001 From: rhit-silkaijr Date: Mon, 27 Oct 2025 21:48:23 -0400 Subject: [PATCH 11/15] v1.63.0 test --- .github/workflows/push.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml index 06ce57b..9b91c98 100644 --- a/.github/workflows/push.yaml +++ b/.github/workflows/push.yaml @@ -56,7 +56,7 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@v2 with: - version: v1.64.2 + version: v1.63.0 skip-pkg-cache: true skip-build-cache: true From b1892ea0901e4dd8f799286921e23ed18cccb2b6 Mon Sep 17 00:00:00 2001 From: rhit-silkaijr Date: Mon, 27 Oct 2025 21:52:36 -0400 Subject: [PATCH 12/15] v1.62.2 --- .github/workflows/push.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml index 9b91c98..ee139d2 100644 --- a/.github/workflows/push.yaml +++ b/.github/workflows/push.yaml @@ -56,7 +56,7 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@v2 with: - version: v1.63.0 + version: v1.62.2 skip-pkg-cache: true skip-build-cache: true From 20cbd0417aac4e993e2e6a0f546de21c278ac102 Mon Sep 17 00:00:00 2001 From: rhit-silkaijr Date: Mon, 27 Oct 2025 21:58:23 -0400 Subject: [PATCH 13/15] testing false check shadowing --- .golangci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index a831514..3a401e4 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -12,7 +12,7 @@ linters-settings: - github.com/satisfactorymodding/ficsit-cli/* govet: - check-shadowing: true + check-shadowing: false enable-all: true disable: - shadow From 0af8b98e2f48c0875f12627e057ee44883824c9f Mon Sep 17 00:00:00 2001 From: rhit-silkaijr Date: Mon, 27 Oct 2025 22:01:15 -0400 Subject: [PATCH 14/15] removing unused --- .golangci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index 3a401e4..7bf1ac6 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -43,7 +43,6 @@ linters: - ineffassign - staticcheck - typecheck - - unused - bidichk - contextcheck - durationcheck From c8360ae80e34419975685b374888e48e3abe0465 Mon Sep 17 00:00:00 2001 From: rhit-silkaijr Date: Mon, 27 Oct 2025 22:05:55 -0400 Subject: [PATCH 15/15] removing revive --- .golangci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index 7bf1ac6..303c4ed 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -43,12 +43,12 @@ linters: - ineffassign - staticcheck - typecheck + - unused - bidichk - contextcheck - durationcheck - errorlint - goimports - - revive - misspell - prealloc - whitespace