Merge branch '11.0'

* 11.0:
  Closes #1131

Author: sebastianbergmann

ChangeLog-12.5.md

@@ -2,6 +2,12 @@
 
 All notable changes are documented in this file using the [Keep a CHANGELOG](http://keepachangelog.com/) principles.
 
+## [12.5.2] - 2025-MM-DD
+
+### Fixed
+
+* [#1131](https://github.com/sebastianbergmann/php-code-coverage/issues/1131): Invalid XML generated when both PCOV and Xdebug are loaded
+
 ## [12.5.1] - 2025-12-08
 
 ### Changed
@@ -23,5 +29,6 @@ All notable changes are documented in this file using the [Keep a CHANGELOG](htt
 * [#1126](https://github.com/sebastianbergmann/php-code-coverage/issues/1126): Add test execution time to `<test>` elements under `projects/tests` in the XML reports index file
 * [#1127](https://github.com/sebastianbergmann/php-code-coverage/issues/1127): Add SHA-1 hash of content of SUT source file to XML report
 
+[12.5.2]: https://github.com/sebastianbergmann/php-code-coverage/compare/12.5.1...main
 [12.5.1]: https://github.com/sebastianbergmann/php-code-coverage/compare/12.5.0...12.5.1
 [12.5.0]: https://github.com/sebastianbergmann/php-code-coverage/compare/12.4.0...12.5.0

src/CodeCoverage.php

@@ -406,6 +406,22 @@ public function validate(TargetCollection $targets): ValidationResult
         return (new TargetCollectionValidator)->validate($this->targetMapper(), $targets);
     }
 
+    /**
+     * @internal
+     */
+    public function driverIsPcov(): bool
+    {
+        return $this->driver->isPcov();
+    }
+
+    /**
+     * @internal
+     */
+    public function driverIsXdebug(): bool
+    {
+        return $this->driver->isXdebug();
+    }
+
     /**
      * @param false|TargetedLines $linesToBeCovered
      * @param TargetedLines       $linesToBeUsed

src/Driver/Driver.php

@@ -76,6 +76,16 @@ public function disableBranchAndPathCoverage(): void
         $this->collectBranchAndPathCoverage = false;
     }
 
+    public function isPcov(): bool
+    {
+        return false;
+    }
+
+    public function isXdebug(): bool
+    {
+        return false;
+    }
+
     abstract public function nameAndVersion(): string;
 
     abstract public function start(): void;

src/Driver/PcovDriver.php

@@ -73,6 +73,11 @@ public function nameAndVersion(): string
         return 'PCOV ' . phpversion('pcov');
     }
 
+    public function isPcov(): true
+    {
+        return true;
+    }
+
     /**
      * @throws PcovNotAvailableException
      */

src/Driver/XdebugDriver.php

@@ -113,6 +113,11 @@ public function nameAndVersion(): string
         return 'Xdebug ' . phpversion('xdebug');
     }
 
+    public function isXdebug(): true
+    {
+        return true;
+    }
+
     /**
      * @throws XdebugNotAvailableException
      * @throws XdebugNotEnabledException

src/Report/Xml/BuildInformation.php

@@ -9,7 +9,6 @@
  */
 namespace SebastianBergmann\CodeCoverage\Report\Xml;
 
-use function phpversion;
 use DateTimeImmutable;
 use SebastianBergmann\Environment\Runtime;
 use XMLWriter;
@@ -24,7 +23,9 @@ public function __construct(
         Runtime $runtime,
         DateTimeImmutable $buildDate,
         string $phpUnitVersion,
-        string $coverageVersion
+        string $coverageVersion,
+        string $driverExtensionName,
+        string $driverExtensionVersion,
     ) {
         $xmlWriter->startElement('build');
         $xmlWriter->writeAttribute('time', $buildDate->format('D M j G:i:s T Y'));
@@ -38,16 +39,8 @@ public function __construct(
         $xmlWriter->endElement();
 
         $xmlWriter->startElement('driver');
-
-        if ($runtime->hasXdebug()) {
-            $xmlWriter->writeAttribute('name', 'xdebug');
-            $xmlWriter->writeAttribute('version', phpversion('xdebug'));
-        }
-
-        if ($runtime->hasPCOV()) {
-            $xmlWriter->writeAttribute('name', 'pcov');
-            $xmlWriter->writeAttribute('version', phpversion('pcov'));
-        }
+        $xmlWriter->writeAttribute('name', $driverExtensionName);
+        $xmlWriter->writeAttribute('version', $driverExtensionVersion);
         $xmlWriter->endElement();
 
         $xmlWriter->endElement();

src/Report/Xml/Facade.php

@@ -10,13 +10,15 @@
 namespace SebastianBergmann\CodeCoverage\Report\Xml;
 
 use const DIRECTORY_SEPARATOR;
+use function assert;
 use function count;
 use function dirname;
 use function file_get_contents;
 use function is_array;
 use function is_dir;
 use function is_file;
 use function is_writable;
+use function phpversion;
 use function sprintf;
 use function strlen;
 use function substr;
@@ -76,21 +78,34 @@ public function process(CodeCoverage $coverage, string $target): void
             $coverage->getReport()->name(),
         );
 
-        $this->setBuildInformation();
+        $this->setBuildInformation($coverage);
 
         $this->project->startProject();
         $this->processTests($coverage->getTests());
         $this->processDirectory($report, $this->project);
         $this->project->finalize();
     }
 
-    private function setBuildInformation(): void
+    private function setBuildInformation(CodeCoverage $coverage): void
     {
+        if ($coverage->driverIsPcov()) {
+            $driverExtensionName    = 'pcov';
+            $driverExtensionVersion = phpversion('pcov');
+        } elseif ($coverage->driverIsXdebug()) {
+            $driverExtensionName    = 'xdebug';
+            $driverExtensionVersion = phpversion('xdebug');
+        }
+
+        assert(isset($driverExtensionName));
+        assert(isset($driverExtensionVersion));
+
         $this->project->buildInformation(
             new Runtime,
             new DateTimeImmutable,
             $this->phpUnitVersion,
             Version::id(),
+            $driverExtensionName,
+            $driverExtensionVersion,
         );
     }
 

src/Report/Xml/Project.php

@@ -41,14 +41,18 @@ public function buildInformation(
         Runtime $runtime,
         DateTimeImmutable $buildDate,
         string $phpUnitVersion,
-        string $coverageVersion
+        string $coverageVersion,
+        string $driverExtensionName,
+        string $driverExtensionVersion,
     ): void {
         new BuildInformation(
             $this->xmlWriter,
             $runtime,
             $buildDate,
             $phpUnitVersion,
             $coverageVersion,
+            $driverExtensionName,
+            $driverExtensionVersion,
         );
     }