From 07e6675ae65211374d68ab4b4ac3eb855c3c4f7c Mon Sep 17 00:00:00 2001 From: Daniel Tao Date: Tue, 9 Dec 2025 15:06:13 -0800 Subject: [PATCH 1/3] build: bump `commander` major version to 14 --- deno.lock | 16 ++++++++-------- package.json | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/deno.lock b/deno.lock index 5253b3e0..f0133813 100644 --- a/deno.lock +++ b/deno.lock @@ -4,7 +4,7 @@ "jsr:@std/assert@1.0.11": "1.0.11", "jsr:@std/fmt@*": "1.0.8", "jsr:@std/internal@^1.0.5": "1.0.12", - "npm:@commander-js/extra-typings@^12.1.0": "12.1.0_commander@12.1.0", + "npm:@commander-js/extra-typings@14": "14.0.0_commander@14.0.2", "npm:@inkjs/ui@2": "2.0.0_ink@5.2.1__@types+react@18.3.27__react@18.3.1_@types+react@18.3.27_react@18.3.1", "npm:@inquirer/prompts@^5.1.2": "5.5.0", "npm:@sfcompute/nodes-sdk-alpha@0.1.0-alpha.27": "0.1.0-alpha.27", @@ -20,7 +20,7 @@ "npm:cli-progress@^3.12.0": "3.12.0", "npm:cli-spinners@*": "3.3.0", "npm:cli-table3@0.6.5": "0.6.5", - "npm:commander@^12.1.0": "12.1.0", + "npm:commander@^14.0.2": "14.0.2", "npm:date-fns@^4.1.0": "4.1.0", "npm:dayjs@^1.11.19": "1.11.19", "npm:dotenv@^16.4.5": "16.6.1", @@ -77,8 +77,8 @@ "@colors/colors@1.5.0": { "integrity": "sha512-ooWCrlZP11i8GImSjTHYHLkvFDP48nS4+204nGb1RiX/WXYHmJA2III9/e2DWVabCESdW7hBAEzHRqUn9OUVvQ==" }, - "@commander-js/extra-typings@12.1.0_commander@12.1.0": { - "integrity": "sha512-wf/lwQvWAA0goIghcb91dQYpkLBcyhOhQNqG/VgWhnKzgt+UOMvra7EX/2fv70arm5RW+PUHoQHHDa6/p77Eqg==", + "@commander-js/extra-typings@14.0.0_commander@14.0.2": { + "integrity": "sha512-hIn0ncNaJRLkZrxBIp5AsW/eXEHNKYQBh0aPdoUqNgD+Io3NIykQqpKFyKcuasZhicGaEZJX/JBSIkZ4e5x8Dg==", "dependencies": [ "commander" ] @@ -420,8 +420,8 @@ "delayed-stream" ] }, - "commander@12.1.0": { - "integrity": "sha512-Vw8qHK3bZM9y/P10u3Vib8o/DdkvA2OtPtZvD871QKjy74Wj1WSKFILMPRPSdUSx5RFK1arlJzEtA4PkFgnbuA==" + "commander@14.0.2": { + "integrity": "sha512-TywoWNNRbhoD0BXs1P3ZEScW8W5iKrnbithIl0YH+uCmBd0QpPOA8yc82DS3BIE5Ma6FnBVUsJ7wVUDz4dvOWQ==" }, "convert-to-spaces@2.0.1": { "integrity": "sha512-rcQ1bsQO9799wq24uE5AM2tAILy4gXGIK/njFWcVQkGNZ96edlpY+A7bjwvzjYvLDyzmG1MmMLZhpcsb+klNMQ==" @@ -1173,7 +1173,7 @@ ], "packageJson": { "dependencies": [ - "npm:@commander-js/extra-typings@^12.1.0", + "npm:@commander-js/extra-typings@14", "npm:@inkjs/ui@2", "npm:@inquirer/prompts@^5.1.2", "npm:@sfcompute/nodes-sdk-alpha@0.1.0-alpha.27", @@ -1186,7 +1186,7 @@ "npm:chrono-node@^2.9.0", "npm:cli-progress@^3.12.0", "npm:cli-table3@0.6.5", - "npm:commander@^12.1.0", + "npm:commander@^14.0.2", "npm:date-fns@^4.1.0", "npm:dayjs@^1.11.19", "npm:dotenv@^16.4.5", diff --git a/package.json b/package.json index e4efe98c..9f6d8630 100644 --- a/package.json +++ b/package.json @@ -7,7 +7,7 @@ "test": "deno test --allow-all" }, "dependencies": { - "@commander-js/extra-typings": "^12.1.0", + "@commander-js/extra-typings": "^14.0.0", "@inkjs/ui": "^2.0.0", "@inquirer/prompts": "^5.1.2", "@sfcompute/nodes-sdk-alpha": "0.1.0-alpha.27", @@ -18,7 +18,7 @@ "chrono-node": "^2.9.0", "cli-progress": "^3.12.0", "cli-table3": "0.6.5", - "commander": "^12.1.0", + "commander": "^14.0.2", "date-fns": "^4.1.0", "dayjs": "^1.11.19", "dotenv": "^16.4.5", From 58402083287a51f3c1278f887e474797bedf5e2c Mon Sep 17 00:00:00 2001 From: Daniel Tao Date: Tue, 9 Dec 2025 15:06:57 -0800 Subject: [PATCH 2/3] fix: use new `--` command flag option to migrate multicharacter short flags --- src/lib/buy/index.tsx | 2 +- src/lib/dev.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/buy/index.tsx b/src/lib/buy/index.tsx index f6454b48..01a3a76a 100644 --- a/src/lib/buy/index.tsx +++ b/src/lib/buy/index.tsx @@ -93,7 +93,7 @@ export function _registerBuy(program: Command) { }) .option("-y, --yes", "Automatically confirm the order") .option( - "-colo, --colocate ", + "--colo, --colocate ", "Colocate with existing contracts. If provided, `-t`/`--type` will be ignored.", ) .option( diff --git a/src/lib/dev.ts b/src/lib/dev.ts index e6f3add6..e8b84eda 100644 --- a/src/lib/dev.ts +++ b/src/lib/dev.ts @@ -55,7 +55,7 @@ function registerConfig(program: Command) { const configCmd = program .command("config") .description("Manage cli config file.") - .option("-rm, --remove", "Remove config file"); + .option("--rm, --remove", "Remove config file"); // sf config // sf config [-rm, --remove] From c40e12df02817b86d017aa0cf99072d3eb26e326 Mon Sep 17 00:00:00 2001 From: Daniel Tao Date: Tue, 9 Dec 2025 15:07:08 -0800 Subject: [PATCH 3/3] fix: breaking change on `-s` --- src/lib/scale/create.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/scale/create.tsx b/src/lib/scale/create.tsx index 6ebe8365..8ac20882 100644 --- a/src/lib/scale/create.tsx +++ b/src/lib/scale/create.tsx @@ -425,7 +425,7 @@ $ sf scale create -n 8 --horizon '30m' ) .addOption( new Option( - "-cs, --colocation-strategy ", + "-s, --colocation-strategy ", `Colocation strategy to use for the procurement. Can be one of \`anywhere\`, \`colocate\`, \`colocate-pinned\`, or \`pinned\`. See https://docs.sfcompute.com/docs/on-demand-and-spot#colocation-behavior for more information.`, ).choices([ "anywhere",