dbIn only works if issued first for a given column

[bwmilby]

The dbIn function will only work if it is the first where function called on that column. The term placeholder(pValue) will always be null since there is no variable pValue in the function call parameter list. dbA["where columns"][pColumn] isn't used anywhere else, but gets set with each where call. I've submitted a pull request with code that addresses this issue.

[bwmilby]

The function will also include the "AND" / "OR" in the list of values if specified. Here is an updated version of the function:

command dbIn pColumn
   
   -- BWM - need to adjust parameter count if concatenation operator is found
   put the paramcount into tParamCount
   put param(tParamCount) into pConcatenationOperator
   
   if pConcatenationOperator is not among the items of "AND,OR" then
      put "AND" into pConcatenationOperator
   else
      put tParamCount - 1 into tParamCount
   end if
   
   -- BWM - properly handle concatenation operator when parenthesis used
   if the last word of dbA["where"] = "(" then
      put empty into pConcatenationOperator
   end if
   
   put "IN" into tOperator
   
   
   if dbA["where"] is empty then
      put "WHERE" && pColumn && "IN("  before dbA["where"]
   else
      put " " & pConcatenationOperator  && pColumn &&  "IN(" after dbA["where"]
   end if
   repeat with x = 2 to tParamCount
      put placeholder(param(x)) & comma after dbA["where"]
   end repeat
   delete char -1 of dbA["where"]
   put ")" after dbA["where"]
end dbIn

There is no validation that enough parameters were included though.

[bwmilby]

#4 addresses this issue.