Requests hanging after previous request.body.read doesn't close

[dishcandanty]

Quick Overview

Previous comment / where this is coming from:
#183 (comment)

I'm experiencing an issue where the body read doesn't seem to close, causing the next request to hang. I suspect its due to a malformed request / bad headers / unusual client.

• Async::HTTP::Server
• request.body.read doesn't seem to close
• request.body.close after request processing solves the issue
• DragonRuby HTTP Client

Reproduce

I've created a minimal reproduce here with more example/data in the readme code
https://github.com/dishcandanty/server-async-hang-reproduce

Overly simplifying:

1. Send request
2. Send second request (hangs on body read)

If the body.close is called, no issue. if the body.read is removed entirely, similarly no issues.

The "http client" where I'm reproducing the hang (haven't been able to reproduce with vanilla curl) is within DragonRuby, specifically using the http_post_body helpers

I haven't been able to reproduce this with vanilla curl even trying to replicate all the request data / headers. Ultimately though, I think its probably a bad thing that some malformed request can indefinitely hold open the server (malicious actors or silly devs doing weird things :D )

[dishcandanty]

I don't know if there is a nice way to have someone run / test the dragonruby side, happy to collect whatever information would be useful / shim into whatever.

[KonnorRogers]

After poking at source code, I would file this under "expected behavior" of body.read since it opens the stream, but never closes the stream, and leaves it up to you to close the stream.

https://github.com/socketry/protocol-http/blob/main/lib/protocol/http/body/readable.rb#L78-L121

If you don't want to have to worry about streaming chunks, to me, it seems the behavior you're after is: body = request.body.join which will give you all buffered chunks as a single string.