-
Notifications
You must be signed in to change notification settings - Fork 59
Open
Labels
False Pass / green failuretype:bugSomething doesn't work as expectedSomething doesn't work as expected
Description
Is your feature request related to a problem? Please describe.
When we reach an xrun, we should stop sof-test scripts. xruns need to be recoverable, but they should never happen. we don't want to miss these issues because the recovery quicks-in and hides problems.
Describe the solution you'd like
Add --fatal-errors to aplay/arecord command-line options.
Example run with --test-position (needs aplay patch to dump the last result)
Status(R/W) (standalone avail=36 delay=924):
state : RUNNING
trigger_time: 2045.504937
tstamp : 2190.754602
delay : 924
avail : 36
avail_max : 444
Status(R/W) (standalone avail=44 delay=912):
state : RUNNING
trigger_time: 2045.504937
tstamp : 2190.754852
delay : 912
avail : 48
avail_max : 48
underrun!!! (at least 471.161 ms long)
Status:
state : XRUN
trigger_time: 2190.786234
tstamp : 2191.257392
delay : 0
avail : 1412
avail_max : 1412
aplay: xrun:1690: fatal underrun: Success
Describe alternatives you've considered
none that I can think of
Additional context
Not sure if we want to add this in sof-test proper, or add this in the environment variables with "APLAY_OPTS" that are already supported.
cc:
Metadata
Metadata
Assignees
Labels
False Pass / green failuretype:bugSomething doesn't work as expectedSomething doesn't work as expected