From 4dafb3808926c861592451b0dd6618c548bb3b52 Mon Sep 17 00:00:00 2001 From: masklinn Date: Sat, 15 Feb 2025 13:58:37 +0100 Subject: [PATCH 1/3] Fix fallback input for release action Apparently the way submodules repos are configured leads to the branches not being mirrored locally (?) As such, the release job's fallback of checking out `'master'` fails whether triggered[^1] or scheduled[^2]. [^1]: https://github.com/ua-parser/uap-python/actions/runs/13090871627 [^2]: https://github.com/ua-parser/uap-python/actions/runs/13092233962 --- .github/workflows/release-builtins.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-builtins.yml b/.github/workflows/release-builtins.yml index 6f41709..f2ad7b8 100644 --- a/.github/workflows/release-builtins.yml +++ b/.github/workflows/release-builtins.yml @@ -28,7 +28,7 @@ jobs: persist-credentials: false - name: update core env: - TAG: ${{ inputs.tag || 'master '}} + TAG: ${{ inputs.tag || 'origin/master '}} # needs to detach because we can update to a tag run: git -C uap-core switch --detach "$TAG" - name: Set up Python From 7bee5177166c01f587c290478d038b91e3976456 Mon Sep 17 00:00:00 2001 From: masklinn Date: Sat, 15 Feb 2025 14:01:06 +0100 Subject: [PATCH 2/3] builtins release: make inputs required for manual triggers --- .github/workflows/release-builtins.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/release-builtins.yml b/.github/workflows/release-builtins.yml index f2ad7b8..fad58c0 100644 --- a/.github/workflows/release-builtins.yml +++ b/.github/workflows/release-builtins.yml @@ -11,9 +11,11 @@ on: tag: description: "uap-core ref to release" type: string + required: true environment: description: "environment to release for (testpypy or pypy)" type: environment + required: true jobs: build: From cbfd031655b58efbcf5a53b6f1e5e2abaa1bb4b8 Mon Sep 17 00:00:00 2001 From: masklinn Date: Sat, 15 Feb 2025 14:02:10 +0100 Subject: [PATCH 3/3] Clarify environment fallback Since the environment is required via `workflow_dispatch`, the only fallback is scheduled release in which case we're publishing to pypy. --- .github/workflows/release-builtins.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-builtins.yml b/.github/workflows/release-builtins.yml index fad58c0..917dd3d 100644 --- a/.github/workflows/release-builtins.yml +++ b/.github/workflows/release-builtins.yml @@ -1,6 +1,6 @@ name: Publish ua-parser builtins -run-name: Publish ${{ inputs.tag || 'master' }} to ${{ inputs.environment || 'dummy' }} +run-name: Publish ${{ inputs.tag || 'master' }} to ${{ inputs.environment || 'pypy (scheduled)' }} on: schedule: