Update messages and minor fixes #56
Open
+76
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanpince
reviewed
Jan 5, 2026
| // Reduce to public if scope claim does not match. | ||
| sessionType = proto.SessionType_Admin | ||
| // Reduce to public if a scope is provided and the claim does not match. | ||
| if scopeClaim != "" && !slices.Contains(strings.Split(scopeClaim, ","), cfg.ServiceName) { |
There was a problem hiding this comment.
I wonder if reducing to public is more confusing here than not. If I make a request with the wrong scope, I would rather get an error, instead of silently getting reduced to public scope.
Contributor
There was a problem hiding this comment.
I agree.
If Admin JWT is scoped to indexer service only -- but is used to make request to other service -- I'd expect the request to fail with HTTP 403 and a clear error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.modand use it inmake protoandmake generate(go 1.25 introduces some compile errors)strings.Contains, we split the scopes using,and check if the service is in the list