feat: make dance.openMenu retain count/register state
#375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, many/most of the unit tests failed due to line ending discrepancies, irrespective of the line endings stored in the test suite source files. After the change, they all pass, again irrespective of the files' line endings.
71
reviewed
May 24, 2025
Owner
71
left a comment
71
left a comment
There was a problem hiding this comment.
Good idea and the PR looks good, thank you! Just one comment:
| flags.push("DoNotReplay"); | ||
| } | ||
|
|
||
| if ("keepephemeral" in f.properties) { |
Owner
There was a problem hiding this comment.
"keepephemeral" has the same casing as other JSDoc tags but is pretty hard to read IMO (especially because of all these p's and e's close together). A couple of alternative ideas: keepcontext, preserve, preservecontext, noreset, noresetstate. I have a slight preference for keepcontext as my brain can easily separate both words, but don't have a strong opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #374.
If the test fix belongs in its own PR, I can make that happen.