Fix Pydantic validation error for Vertex Tensorboard args #2893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running MaxText benchmarks,
use_vertex_tensorboardandvertex_tensorboard_projectmay be converted toNone. TheMaxTextConfigPydantic model currently enforces strict string types, causing aValidationError(Input should be a valid string).This change updates the config definition to
Optional[str]. This allows the fields to acceptNoneduring validation.Error Log
Tests
python3 -m benchmarks.benchmark_runner on-device --base_output_directory gs://maxtext-test/ --run_name="test-run" --num_steps=5Logs
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.