pldmtool: File I/O & checksum options for mctpRaw #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spargaon
force-pushed
the
fwdeve125145_review_28
branch
from
411d664 to
e59f678
Compare
Collaborator
Author
|
$ pldmtool mctpraw -e 1 -m 15 --data 0x00 0x80 0x0a 0x00 root@congo-0234:/tmp# rm outf root@congo-0234:/tmp# rm outf |
mahkurap
requested changes
Jan 7, 2026
spargaon
force-pushed
the
fwdeve125145_review_28
branch
from
e59f678 to
f24a061
Compare
mahkurap
approved these changes
Jan 7, 2026
Collaborator
Author
srgovard
approved these changes
Jan 7, 2026
Enhance the `mctpRaw` subcommand with options to read request data from a file (`--file-in`), write response data to a file (`--file-out`), and append or validate checksum (`--checksum`). These additions improve usability for large payloads and ensure data integrity during raw MCTP transactions. Contents of the file specified in option --file-in are appended to the contents of the option --data. Signed-off-by: Shirish Pargaonkar <Shirish.Pargaonkar@amd.com>
spargaon
force-pushed
the
fwdeve125145_review_28
branch
from
f24a061 to
518c68f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the
mctpRawsubcommand with options to read request data from a file (--file-in), write response data to a file (--file-out), and append or validate checksum (--checksum). These additions improve usability for large payloads and ensure data integrity during raw MCTP transactions.Contents of the file specified in option --file-in are appended to the contents of the option --data.