Fix url scraping in getStreamUrlNew() #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems a site update has changed from using double to single quotes which breaks the url scraper. Updated regex to catch both single and double quotes.
Closed
- convert items to utf-8 encoded strings using helper function str_item().
- Doesn't seem to be required as the title data from json is clean from html encodings - Keep the function for now in case needed later.
Conflicts: default.py
We don't need to prepend baseUrl.
Instead of regex we use the json module to find the stream url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems a site update has changed from using double to single quotes
which breaks the url scraper.
Updated regex to catch both single and double quotes.