Skip to content

Definitions lookup with lazy operator #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AgranatMarkit wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Definitions lookup with lazy operator #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eba0dca
Fix test compilation for Xcode 12.5
AgranatMarkit Oct 18, 2021
e390754
Use containes operator instead of filter + isEmpty
AgranatMarkit Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Resolve.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ extension DependencyContainer {

//if no definition registered for exact type try to find type-forwarding definition that can resolve the type
//that will actually happen only when resolving optionals
if definitions.filter({ $0.0.type == key.type }).isEmpty {
guard definitions.contains(where: { $0.0.type == key.type }) else {
return typeForwardingDefinition(forKey: key)
}
return nil
Expand Down
8 changes: 4 additions & 4 deletions Tests/DipTests/AutoInjectionTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,12 @@ private class ClientImp: Client {

@Injected(didInject: { _ in
AutoInjectionTests.serverDidInjectCalled = true
}) var server: Server
}) var server: Server?

@Injected(required: false) var _optionalProperty: AnyObject?

@Injected(tag: "tagged") var taggedServer: Server
@Injected(tag: nil) var nilTaggedServer: Server
@Injected(tag: "tagged") var taggedServer: Server?
@Injected(tag: nil) var nilTaggedServer: Server?

var anotherServer: Server!
}
Expand Down