DPL: earlier forwarding #14910
Open
DPL: earlier forwarding #14910
+235
−172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a single helper function to improve readability.
If one (header, payload, ...) tuple in a MessageSet was to be copied, all the subsequent ones would have been copied. If one (header, payload, ...) tuple got redirected to more than one destination, all the subsequent ones would have been redirected there.
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Member
Author
|
@shahor02 this works in my synthetic tests (stage/bin/o2-testworkflows-early-forwarding -s --severity detail --early-forward-policy=always) . In the end I refactored the code to find the earliest spot where messages are guaranteed to be seen only once and I moved the early forward there. @davidrohr @shahor02 I have noticed that the early forwarding is disabled by default. Is this expected? |
Member
Author
|
@jgrosseo @nicolaspoffley I expect this to improve parallelism on hyperloop as well. |
Collaborator
|
@ktf for me it is not expected that the EF is disabled, when I was debugging the slow turnover of Polaris jobs, I thought the forwarding is done at the beginning of run method. Was not this the supposed behaviour of the EF? |
Member
Author
|
@shahor02 I need to have a better look. Maybe it's just my small reproducer to be wrong. I also see there is some issues with some of the tests. I will debug better tomorrow morning. |
Collaborator
This is most likely faster, and it will allow us to move the early forwarding at an earlier stage where the data is not yet in a MessageSet.
Add splitPayloadIndex / splitPayloadParts to the default printout
This anticipates the forwarding to the earliest possible moment, i.e. when we are about to insert the messages in a slot. This is the earliest moment we can guarantee messages will be seen only once.
Member
Author
|
Ok, fixed the off by one issue with multiparts. |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for f6dfcce at 2025-12-28 21:37: Full log here. |
Collaborator
For online and offline reco we enable it here: https://github.com/davidrohr/O2DPG/blob/a5af1be2a96bbe3b2eeb2cf13d41c4afd1b81e4a/DATA/common/getCommonArgs.sh#L12 |
Collaborator
|
@ktf this seems to be genuine crash: |
Member
Author
|
@shahor02 indeed. I am investigating. |
Member
Author
|
I suspect it's an issue with the back pressure. I will try to replicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This anticipates the forwarding to the earliest possible moment, i.e. when
we are about to insert the messages in a slot. This is the earliest moment
we can guarantee messages will be seen only once.
Stack created with Sapling. Best reviewed with ReviewStack.