Two improvements for the MC anchoring service #1890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Greater flexibility to set the timeframe length in orbits.
The `--orbitsPerTF` options now,
* either takes a precise integer number
* or a comma-separated string of triples f:t:o
which denote to use `o` orbits when the interaction rate falls between
`f` (inclusive) and `t` (exclusive)
example: `--orbitsPerTF 0:10000:32,10001:10000000:8` will apply
32 orbit-sizes timeframes when the interaction rate is below 10kHz, otherwise
8 orbits.
This improvement caused a larger refactoring of the code, because we now
need to query the interaction rate twice.
2) Improvements in the bad-data exlusion treatment:
* We now report the global fraction of run-space excluded by the list
* We now determine each line, wether the treatment is in orbits or in timestamps
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greater flexibility to set the timeframe length in orbits.
The
--orbitsPerTFoptions now,either takes a precise integer number
or a comma-separated string of triples f:t:o which denote to use
oorbits when the interaction rate falls betweenf(inclusive) andt(exclusive)example:
--orbitsPerTF 0:10000:32,10001:10000000:8will apply 32 orbit-sizes timeframes when the interaction rate is below 10kHz, otherwise 8 orbits.This improvement caused a larger refactoring of the code, because we now
need to query the interaction rate twice.
Improvements in the bad-data exlusion treatment: