Skip to content

Conversation

@nburmaso
Copy link
Contributor

@nburmaso nburmaso commented Feb 5, 2025

Port of the generator used in Run 2 for MC tuning and efficiency studies in the muon spectrometer
Original: https://github.com/alisw/AliDPG/blob/master/MC/CustomGenerators/PWGDQ/Muon_GenParamSingle_PbPb5TeV_1.C

@nburmaso nburmaso requested a review from a team as a code owner February 5, 2025 13:30
@github-actions
Copy link

github-actions bot commented Feb 5, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@nburmaso
Copy link
Contributor Author

nburmaso commented Feb 5, 2025

@lmassacr, could you please check?

@nburmaso nburmaso closed this Feb 5, 2025
@nburmaso nburmaso reopened this Feb 5, 2025
@github-actions
Copy link

github-actions bot commented Feb 5, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@lmassacr
Copy link
Contributor

lmassacr commented Feb 5, 2025

Hi @nburmaso ,
Thanks for the work. The settings look globally ok to me.

@nburmaso
Copy link
Contributor Author

nburmaso commented Feb 6, 2025

Hi @sawenzel,

It seems there are now issues with the code. Could you please merge this PR?

Cheers,
Nazar

@sawenzel
Copy link
Contributor

sawenzel commented Feb 6, 2025

In principle there is a PWG-DQ review team. When they approve the PR is merged automatically. Maybe we should update that list?

@sawenzel sawenzel merged commit 8fc1003 into AliceO2Group:master Feb 6, 2025
14 checks passed
@lmassacr
Copy link
Contributor

lmassacr commented Feb 6, 2025

Hi @nburmaso ,
I am not sure but did you saw the few comments I made above? I had 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants