Skip to content

Conversation

@fgrosa
Copy link
Contributor

@fgrosa fgrosa commented Apr 30, 2025

This PR adds the possibility to replace particles in the PYTHIA stack with a given frequency. Custom particles, not present in PYTHIA, are also allowed (specifically for the moment Ds1* and Ds3* states and Xic resonances).

It also adds a config for the MC production needed for the analyses of Ds and Xic excited states with 2024 pp triggered data (Ds1+, Ds2*+ and excited Xic states)

Please @Luca610 check the forced decays, in case we want to add something.

@fgrosa fgrosa requested a review from a team as a code owner April 30, 2025 07:48
@github-actions
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@fgrosa fgrosa changed the title Add possibility to replace particles in the stack for HF generator [PWGHF] Add possibility to replace particles in the stack for HF generator Apr 30, 2025
Copy link
Contributor

@stefanopolitano stefanopolitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fgrosa ! Thanks for the development. I don't have particular comments, approved.

@Luca610
Copy link
Contributor

Luca610 commented Apr 30, 2025

Hi @fgrosa, thank you very much for your implementation!
I have no particolar comments on the decays added, they look good to me.
I was thinking if it could be worth it to add also the neutral counterpart to the excited Xc resonances in the D0 Lambda decay, but I don't know what particle could be a good candidate for the replacement....
Thanks again!

@sawenzel
Copy link
Contributor

There is crash in a generator test GeneratorHF_D2H_ccbar_and_bbbar_gap5_DResoTrigger.ini_External_dir/o2dpg-test-kine.log:

Test 2: /O2DPG/MC/config/PWGHF/ini/GeneratorHF_D2H_ccbar_and_bbbar_PbPb_ptHardBins.ini with generator External�[0;32m -> PASSED�[0m
�[0;31mError found in log /sw/BUILD/4eceb745b50932d543e32dd7b5b9070caa22b2f7/O2DPG-sim-tests/o2dpg-sim_tests/o2dpg_tests/generators/0_GeneratorHF_D2H_ccbar_and_bbbar_gap5_DResoTrigger.ini_External_dir/o2dpg-test-kine.log�[0m
503-namespace o2{namespace dataformats{class __attribute__((annotate("$clingAutoload$SimulationDataFormat/MCEventHeader.h")))  MCEventHeader;}}
504-namespace o2{namespace data{struct PrimaryChunk;}}
505-namespace o2{namespace steer{class DigitizationContext;}}
506-namespace o2{namespace dataformats{class IOMCTruthContainerView;}}
507-namespace o2{namespace mcutils{class MCTrackNavigator;}}
508-namespace o2{namespace mcutils{class MCGenHelper;}}
509-namespace o2{namespace steer{class InteractionSampler;}}
510-namespace o2{using MCTrack = MCTrackT<float>;}
511-'
512-
513: *** Break *** segmentation violation
514-
515-
516-
517-===========================================================
518-There was a crash.
519-This is the entire stack trace of all threads:
520-===========================================================
521-#0  0x00007f5abc0d0afa in wait4 () from /lib64/libc.so.6
522-#1  0x00007f5abc043283 in do_system () from /lib64/libc.so.6
523-#2  0x00007f5abc96290a in TUnixSystem::Exec (this=0x18b6680, shellcmd=<optimized out>) at /local/workspace/DailyBuilds/DailyO2Physics-slc9/daily-tags.ViqGjj4BXe/SOURCES/ROOT/v6-32-06-alice7/v6-32-06-alice7/core/unix/src/TUnixSystem.cxx:2157
##############################
# Run O2DPG workflow testing #
##############################
==> Test outline

Is this related to this PR?

@fgrosa
Copy link
Contributor Author

fgrosa commented Apr 30, 2025

Hi @fgrosa, thank you very much for your implementation! I have no particolar comments on the decays added, they look good to me. I was thinking if it could be worth it to add also the neutral counterpart to the excited Xc resonances in the D0 Lambda decay, but I don't know what particle could be a good candidate for the replacement.... Thanks again!

Thanks! Indeed this is a good point, I added them as replacement of the 425. Even if I don't trigger on 425, there are enough replaced neutral excited Xic

@fgrosa
Copy link
Contributor Author

fgrosa commented Apr 30, 2025

There is crash in a generator test GeneratorHF_D2H_ccbar_and_bbbar_gap5_DResoTrigger.ini_External_dir/o2dpg-test-kine.log:

Test 2: /O2DPG/MC/config/PWGHF/ini/GeneratorHF_D2H_ccbar_and_bbbar_PbPb_ptHardBins.ini with generator External�[0;32m -> PASSED�[0m
�[0;31mError found in log /sw/BUILD/4eceb745b50932d543e32dd7b5b9070caa22b2f7/O2DPG-sim-tests/o2dpg-sim_tests/o2dpg_tests/generators/0_GeneratorHF_D2H_ccbar_and_bbbar_gap5_DResoTrigger.ini_External_dir/o2dpg-test-kine.log�[0m
503-namespace o2{namespace dataformats{class __attribute__((annotate("$clingAutoload$SimulationDataFormat/MCEventHeader.h")))  MCEventHeader;}}
504-namespace o2{namespace data{struct PrimaryChunk;}}
505-namespace o2{namespace steer{class DigitizationContext;}}
506-namespace o2{namespace dataformats{class IOMCTruthContainerView;}}
507-namespace o2{namespace mcutils{class MCTrackNavigator;}}
508-namespace o2{namespace mcutils{class MCGenHelper;}}
509-namespace o2{namespace steer{class InteractionSampler;}}
510-namespace o2{using MCTrack = MCTrackT<float>;}
511-'
512-
513: *** Break *** segmentation violation
514-
515-
516-
517-===========================================================
518-There was a crash.
519-This is the entire stack trace of all threads:
520-===========================================================
521-#0  0x00007f5abc0d0afa in wait4 () from /lib64/libc.so.6
522-#1  0x00007f5abc043283 in do_system () from /lib64/libc.so.6
523-#2  0x00007f5abc96290a in TUnixSystem::Exec (this=0x18b6680, shellcmd=<optimized out>) at /local/workspace/DailyBuilds/DailyO2Physics-slc9/daily-tags.ViqGjj4BXe/SOURCES/ROOT/v6-32-06-alice7/v6-32-06-alice7/core/unix/src/TUnixSystem.cxx:2157
##############################
# Run O2DPG workflow testing #
##############################
==> Test outline

Is this related to this PR?

Hi @sawenzel, yes it looks like so (I have tested the ini and it works properly but not the test macro itself, so likely the issue is there, checking now)

@fgrosa
Copy link
Contributor Author

fgrosa commented Apr 30, 2025

Hi @fgrosa, thank you very much for your implementation! I have no particolar comments on the decays added, they look good to me. I was thinking if it could be worth it to add also the neutral counterpart to the excited Xc resonances in the D0 Lambda decay, but I don't know what particle could be a good candidate for the replacement.... Thanks again!

Thanks! Indeed this is a good point, I added them as replacement of the 425. Even if I don't trigger on 425, there are enough replaced neutral excited Xic

It should be fixed with 972f232 (it also fixes a small bug introduced in 98d2c7c)

@stefanopolitano stefanopolitano merged commit 05fde30 into AliceO2Group:master Apr 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants