Skip to content

Conversation

@alcaliva
Copy link
Collaborator

…with phi range selection

@alcaliva alcaliva requested a review from a team as a code owner May 10, 2025 08:32
@github-actions
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alcaliva alcaliva enabled auto-merge (squash) May 10, 2025 08:33
@alcaliva
Copy link
Collaborator Author

@njacazio and @gvolpe79, I modified the existing generator making it more flexible by allowing the selection of eta and phi ranges (default values are -1<eta<1 and 0<phi<pi) to inject particles into HMPID acceptance. I also added the ini file which generates PbPb events and injects 10 (anti)deuterons using the modified generator_pythia8_longlived.C version

@alcaliva alcaliva added async-2023-PbPb-apass5 async-2024-PbPb-apass2 async-2022-pp-apass7 Request porting to async-2022-pp-apass7 async-2023-pp-apass4 Request porting to async-2023-pp-apass4 labels May 10, 2025
@alcaliva
Copy link
Collaborator Author

Hi @sawenzel,

I get this error which I do not understand:

/O2DPG/MC/config/PWGLF/pythia8/generator_pythia8_longlived.C:46:28: error: only virtual member functions can be marked 'override'
Bool_t importParticles() override

isn't this supposed to override a virtual method in the base class, as it used to do? Why all of a sudden it doesn't work here? Any clue? Thanks

Copy link
Contributor

@njacazio njacazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Alberto

@alcaliva alcaliva merged commit a484fd4 into AliceO2Group:master May 10, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async-2022-pp-apass7 Request porting to async-2022-pp-apass7 async-2023-PbPb-apass5 async-2023-pp-apass4 Request porting to async-2023-pp-apass4 async-2024-PbPb-apass2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants