Fix mother -> daughter indices in case of replacement in HF gerator #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
stefanopolitano
approved these changes
Jun 1, 2025
Contributor
stefanopolitano
left a comment
stefanopolitano
left a comment
There was a problem hiding this comment.
Hi @fgrosa ! Thanks for the development. No comments form my side. Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the history in case of particle replacement.
In particular, the indices of the mothers of the replaced particles are not updated correctly after
removeand it is necessary in case ofincludePartonEvent=false(while not important if we keep the parton event, since the new particle -> mothers indices are always OK).