-
Notifications
You must be signed in to change notification settings - Fork 615
[PWGJE] Addition of deltaEta and deltaPhi columns to the EmcalMatchedTracks tables in the JE framework + fixed some bugs in the full-jet-spectra task #12942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… modified the usage of dEta and dPhi accordingly in the EMCAL Hadronic correction task
|
O2 linter results: ❌ 112 errors, |
|
okay, now I have no clue why the alibuild checks are failing. From the logs, it is not very clear to me either. |
|
Hey @Archita-Dash |
|
Hi Archita. The PR looks good to me. Only small thing is the naming of DeltaEta and DeltaPhi. Are these really anglular differences? Maybe we can find a better name so its not confused for the DeltaEta and DeltaPhi used for DeltaR calculations. Thanks, |
|
Hi Nima, |
Hi Nima, Cheers. |
|
Thanks for the info. Howabout EtaDiff and PhiDiff? |
Okay but do these names require to be first changed in the emcal table producer task? Or I can only change within the JE framework? |
You can change them just in the JE framework. The emcal table or table producer does not need to be changed for this. |
Can either of you please guide me where exactly to make the necessary changes? If I am being correct, And then replaced all previous instances of deltaEta() and deltaPhi() from the other JE tasks - deriveddataproducer, deriveddataWriter and emcalHadronic correction tasks. However, that throws me the following errors when building locally: |
|
hi Nima, Cheers, |
Hey Archita, When you fill the table, you still use the emcal table so you need to use the |
Hey Marvin, thanks a lot! Yes, you were right indeed. And now I have pushed the changes and it seemed to have successfully passed all the build checks. Could this PR be approved soon please? Cheers |
…Tracks tables in the JE framework + fixed some bugs in the full-jet-spectra task (AliceO2Group#12942)
…Tracks tables in the JE framework + fixed some bugs in the full-jet-spectra task (AliceO2Group#12942)
…Tracks tables in the JE framework + fixed some bugs in the full-jet-spectra task (AliceO2Group#12942)
…Tracks tables in the JE framework + fixed some bugs in the full-jet-spectra task (AliceO2Group#12942)
…Tracks tables in the JE framework + fixed some bugs in the full-jet-spectra task (AliceO2Group#12942)
Hi Nima,
In this PR, I have added the deltaEta and deltaPhi columns following Marvin's PR : #12244
Also, I have fixed few minor bugs in my analysis task.
Cheers,
Archita