[PWGCF] : Flow Event Plane #13740
Merged
[PWGCF] : Flow Event Plane #13740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated PID response includes a new PIDResponse header and added several configurable parameters for track selection and analysis. Adjusted histogram definitions and gain calibration logic to use the current run number.
yashpatley
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
shouqiye,
victor-gonzalez and
zchochul
as code owners
|
O2 linter results: ❌ 0 errors, |
victor-gonzalez
requested changes
Nov 9, 2025
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Please, rebase your changes to the latest version
PWGCF/Flow/Tasks/flowEventPlane.cxx
Outdated
| #include "Common/DataModel/Multiplicity.h" | ||
| #include "Common/DataModel/PIDResponseTOF.h" | ||
| #include "Common/DataModel/PIDResponseTPC.h" | ||
| #include "Common/DataModel/PIDResponse.h" |
Collaborator
There was a problem hiding this comment.
Please, rebase your changes to the latest version of O2Physics
This is rolling back a previous centralized change
PWGCF/Flow/Tasks/flowEventPlane.cxx
Outdated
Comment on lines
143
to
147
| struct CorrHistContainer { | ||
| TH2F* hGainCalib; | ||
| std::array<std::array<THnSparseF*, 1>, 4> vCoarseCorrHist; | ||
| std::array<std::array<TProfile*, 4>, 4> vFineCorrHist; | ||
| } CorrHistContainer; |
Collaborator
There was a problem hiding this comment.
Names are cheap in programming!
I would suggest Correction instead of Corr to distinguish from Correlation
| getResoFlow(tracks, vSP); | ||
|
|
||
| // Update run number | ||
| lRunNum = cRunNum; |
Collaborator
There was a problem hiding this comment.
Any reason for needing two?
Contributor
Author
There was a problem hiding this comment.
Yes, for the current implementation to fetch correction factors once per run, it is required. I couldn't think of any other way.
victor-gonzalez
approved these changes
Nov 10, 2025
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated PID response includes a new PIDResponse header and added several configurable parameters for track selection and analysis. Adjusted histogram definitions and gain calibration logic to use the current run number.