Skip to content

Gradient fix #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hannesa2 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Gradient fix #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d1f11e
Gradient fix
hannesa2 Dec 27, 2025
a2700e3
Adapt new screenshots
hannesa2 Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions chartLib/src/main/kotlin/info/appdev/charting/renderer/LineChartRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,17 +412,7 @@ open class LineChartRenderer(
if (currentStartIndex <= currentEndIndex) {
val drawable = dataSet.fillDrawable

var startIndex = currentStartIndex
var endIndex = currentEndIndex

// Add a little extra to the path for drawables, larger data sets were showing space between adjacent drawables
if (drawable != null) {
startIndex = max(0.0, (currentStartIndex - 1).toDouble()).toInt()
endIndex = min(endingIndex.toDouble(), (currentEndIndex + 1).toDouble()).toInt()
}

generateFilledPath(dataSet, startIndex, endIndex, filled)

generateFilledPath(dataSet, currentStartIndex, currentEndIndex, filled)
Copy link
Collaborator Author

@hannesa2 hannesa2 Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turtleandr

I guess this is your suggested change. Let's see if screenshot diff shows the desired result

Copy link

@turtleandr turtleandr Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hannesa2 yes, exactly

trans.pathValueToPixel(filled)

if (drawable != null) {
Expand Down
Binary file modified ...Compare9/StartTest_smokeTestStart-42-GradientActivity-Gradient-1SampleClick.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading