Skip to content

Conversation

@oZakari
Copy link
Contributor

@oZakari oZakari commented Aug 15, 2024

Pull Request

This pull request includes several updates to the documentation and PowerShell scripts to improve clarity and functionality. The most important changes are grouped into documentation updates and PowerShell script improvements.

Documentation Updates:

PowerShell Script Improvements:

  • Added a replaceFiles switch parameter to the New-ALZEnvironmentBicep function and included logic to conditionally overwrite the configuration directory based on this parameter in src/ALZ/Private/Legacy-Bicep/New-ALZEnvironmentBicep.ps1 [1] [2].
  • Corrected a typo in the Get-GithubRelease function to change "over-writing" to "overwriting" in src/ALZ/Private/Shared/Get-GithubRelease.ps1.
  • Removed unnecessary whitespace and adjusted variable initialization in the New-ALZEnvironment function in src/ALZ/Public/New-ALZEnvironment.ps1 [1] [2] [3].

Issue

Fixes Azure/Azure-Landing-Zones#2509
Fixes Azure/Azure-Landing-Zones#2654
Fixes AB

Description of changes:

License

By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.

@oZakari oZakari added the Type: Bug 🪲 Something isn't working label Aug 15, 2024
@oZakari oZakari requested a review from jaredfholgate August 15, 2024 05:11
@oZakari oZakari changed the title Fix logic for Bicep legacy upgrades and creation Fix logic for Bicep legacy upgrades/creation and wiki Aug 15, 2024
@oZakari oZakari requested a review from sebassem August 26, 2024 20:16
Copy link
Contributor

@sebassem sebassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari merged commit aaa460c into Azure:main Aug 27, 2024
@oZakari oZakari deleted the fix-classic-accel branch February 5, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug 🪲 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

custom-parameters, azuredevops\pipelines and pipeline scripts Incorrect PowerShell commands on [User Guide] Quick Start Phase 2 GitHub wiki page

2 participants