Skip to content

Conversation

@lovelysandwich
Copy link
Contributor

@lovelysandwich lovelysandwich commented Mar 29, 2023

Pull Request

Issue

Azure/Azure-Landing-Zones#2568
Azure/Azure-Landing-Zones#2557

Description

Adding functionality to modify values before they're set based on simple PowerShell expressions...

This might be questionable - but I couldn't think of another way to easily deal with lots of situations where logic would need to be executed in response to user input.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.

},
"AllSubscriptionIds": {
"Type": "Computed",
"Process": "@($args | Select-Object -Unique)",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to consider casing here... Perhaps tolower on the inputs before we test for uniqueness...

Copy link
Member

@Nepomuceno Nepomuceno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lovelysandwich lovelysandwich marked this pull request as ready for review March 30, 2023 09:52
@lovelysandwich lovelysandwich merged commit b84cecc into main Mar 30, 2023
@lovelysandwich lovelysandwich deleted the fixing_workspace_location_and_subs branch March 30, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants