Skip to content

fix: pin to bootstrap module version #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
VeronicaSea wants to merge 3 commits into from
Closed

fix: pin to bootstrap module version #264

VeronicaSea wants to merge 3 commits into from

Conversation

@VeronicaSea
Copy link
Collaborator

@VeronicaSea VeronicaSea commented Dec 13, 2024

Pull Request

Pin to bootstrap module version.

Description

Pin to bootstrap module version.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.

@VeronicaSea VeronicaSea changed the title Fix: Pin to bootstrap module version. fix: Pin to bootstrap module version. Dec 13, 2024
@sdeguchi sdeguchi self-requested a review December 13, 2024 19:29
sdeguchi
sdeguchi previously approved these changes Dec 13, 2024
View reviewed changes
@VeronicaSea VeronicaSea added the Type: Documentation 📄 Improvements or additions to documentation label Dec 13, 2024
@jaredfholgate jaredfholgate changed the title fix: Pin to bootstrap module version. fix: pin to bootstrap module version Dec 13, 2024
jaredfholgate
jaredfholgate requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to release @sdeguchi change here Azure/accelerator-bootstrap-modules#61 as v4.1.6 once the tests pass. Do you want to update this PR to match that version?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Needs the author to provide feedback label Dec 19, 2024
@sdeguchi
Copy link
Collaborator

sdeguchi commented Dec 19, 2024

I plan to release @sdeguchi change here Azure/accelerator-bootstrap-modules#61 as v4.1.6 once the tests pass. Do you want to update this PR to match that version?

@jaredfholgate this PR contains the version that we would like to pin SLZ to for the accelerator-bootstrap-modules. Additionally, I created a PR into the alz-terraform-accelerator to update the inputs files that were recently added there. Azure/alz-terraform-accelerator#189

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 Needs the author to provide feedback label Dec 19, 2024
@VeronicaSea
Copy link
Collaborator Author

VeronicaSea commented Dec 19, 2024

I plan to release @sdeguchi change here Azure/accelerator-bootstrap-modules#61 as v4.1.6 once the tests pass. Do you want to update this PR to match that version?

Hi @jaredfholgate , we have to pin to v4.1.2 and v4.1.6 is not compatible for our existing accelerator start module.

@jaredfholgate
Copy link
Member

jaredfholgate commented Jan 7, 2025

No longer required, changes have been made in a separate branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredfholgate jaredfholgate jaredfholgate requested changes

@sdeguchi sdeguchi sdeguchi left review comments

Assignees

No one assigned

Labels

Type: Documentation 📄 Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VeronicaSea @sdeguchi @jaredfholgate