Skip to content

Conversation

@lovelysandwich
Copy link
Contributor

@lovelysandwich lovelysandwich commented Mar 30, 2023

Pull Request

Issue

Fixes Azure/Azure-Landing-Zones#2552
Fixes Azure/Azure-Landing-Zones#2553

Description

Changes to ensure that subscription ids persist as an array when only one value remains.
Handling case insensitive deduplication of subscription ids.
Fixes a part of the ReadMe.md (probably more work required, but fixing a small part of that document)

License

By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.

@lovelysandwich lovelysandwich marked this pull request as ready for review March 30, 2023 15:22
@lovelysandwich lovelysandwich added bug Something isn't working major patch and removed major labels Mar 30, 2023
Copy link
Member

@Nepomuceno Nepomuceno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lovelysandwich lovelysandwich merged commit 8313d67 into main Mar 30, 2023
@lovelysandwich lovelysandwich deleted the fixing_subscription_values branch March 30, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patch

Projects

None yet

3 participants