Update Get-ALZGithubRelease.ps1 #86
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for pagination of Github releases
Contributor
|
Hi @MarkFarkas, thanks for creating this PR. Could you update the unit tests for this change as it looks like the while loop is creating an infinite loop with the current test configuration. See https://github.com/Azure/ALZ-PowerShell-Module/actions/runs/6536909020/job/17749625852?pr=86 |
Contributor
|
Never mind, looks like the requests are getting blocked by GitHub with a 403 forbidden response. Just going to wait a bit before running again as there may be some issues with GitHub atm as I am experiencing issues locally as well. |
Contributor
|
Function refactored with the following PR: #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for pagination of Github releases
Pull Request
Issue
Fixes Azure/Azure-Landing-Zones#2536
Description
Description of changes: Add support for pagination when calling the releases endpoint on the GitHub API.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.